public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: Adolf Belka <adolf.belka@ipfire.org>
Cc: development@lists.ipfire.org
Subject: Re: [PATCH] index.cgi: Add wireguard status to home screen
Date: Mon, 26 May 2025 11:12:34 +0100	[thread overview]
Message-ID: <C445220E-6DAD-464F-BE30-0EC58EF6E4BC@ipfire.org> (raw)
In-Reply-To: <20250525113501.9516-1-adolf.belka@ipfire.org>

Hello Adolf,

Thank you for this patch.

I have made some further changes to this, but in essence I agree with it:

  https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=c29a07b2ee505811a6cd78ca643bf816beb77375
  https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=9f1f3da8f5866098177edd68ef50b238a3dadf6a
  https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=8277dec16614df36ed0bd6f687ce244c2d243c62 (not too related)
  https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=c00e6e49c3cd0ba0fa3826539c251d757f41bc9a

Should we also add the N2N connections?

-Michael

> On 25 May 2025, at 12:35, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - This fix adds a wireguard line to show when it is enabled.
> - This fix does not show a table for any net2net connections that are enabled. I have
>   started working on that but as I only have an OpenVPN n2n connection in place, I can't
>   test out the copy of the ipsec n2n code section that I have made. I need to get ipsec
>   and wireguard n2n connections working first.
> - If someone else wants to provide a patch for the wireguard n2n connections tables I have
>   no problems with that. If not then I will submit one when I have been able to test it.
> 
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> html/cgi-bin/index.cgi | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/index.cgi b/html/cgi-bin/index.cgi
> index d9c74ce7f..e28629cc9 100644
> --- a/html/cgi-bin/index.cgi
> +++ b/html/cgi-bin/index.cgi
> @@ -2,7 +2,7 @@
> ###############################################################################
> #                                                                             #
> # IPFire.org - A linux based firewall                                         #
> -# Copyright (C) 2007-2023  IPFire Team  <info@ipfire.org>                     #
> +# Copyright (C) 2007-2025  IPFire Team  <info@ipfire.org>                     #
> #                                                                             #
> # This program is free software: you can redistribute it and/or modify        #
> # it under the terms of the GNU General Public License as published by        #
> @@ -39,6 +39,7 @@ my %netsettings=();
> my %ddnssettings=();
> my %proxysettings=();
> my %vpnsettings=();
> +my %wgsettings=();
> my %vpnconfig=();
> my %ovpnconfig=();
> my $warnmessage = '';
> @@ -60,6 +61,7 @@ $pppsettings{'PROFILENAME'} = 'None';
> &General::readhash("${General::swroot}/ddns/settings", \%ddnssettings);
> &General::readhash("${General::swroot}/proxy/advanced/settings", \%proxysettings);
> &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
> +&General::readhash("${General::swroot}/wireguard/settings", \%wgsettings);
> 
> my %color = ();
> my %mainsettings = ();
> @@ -369,7 +371,21 @@ print <<END;
> <td style='width:45%; text-align:center; color:$Header::colourgreen;'>Online</td>
> </tr>
> END
> - }
> +}
> +
> +#check if WireGuard is running
> +if ( $wgsettings{'ENABLED'} eq 'on' ) {
> +print<<END;
> + <tr>
> + <td style='width:25%; text-align:center; background-color:$Header::colourwg;'>
> + <a href='/cgi-bin/wireguard.cgi' style='color:white'><b>$Lang::tr{'wg'}</b></a>
> + </td>
> + <td style='width:30%; text-align:center;'></td>
> + <td style='width:45%; text-align:center; color:$Header::colourgreen;'>Online</td>
> + </tr>
> +END
> +}
> +
> print"</table>";
> &Header::closesection();
> 
> -- 
> 2.49.0
> 
> 



  reply	other threads:[~2025-05-26 10:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-25 11:35 Adolf Belka
2025-05-26 10:12 ` Michael Tremer [this message]
2025-05-26 12:10   ` Adolf Belka
2025-05-26 13:43     ` Michael Tremer
2025-05-26 15:29       ` Adolf Belka
2025-05-28  9:30         ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C445220E-6DAD-464F-BE30-0EC58EF6E4BC@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox