public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/4] graphs.pl: fix spelling of "SYN"
Date: Mon, 27 Apr 2020 16:33:16 +0100	[thread overview]
Message-ID: <C71BE969-6073-4128-BC14-20DA834C6C9A@ipfire.org> (raw)
In-Reply-To: <5e1ca950-4738-3676-0de6-fb62d48c6ed6@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 27 Apr 2020, at 16:24, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> This merely is a cosmetic change, but since we are dealing with network
> packets here, the SYN flag must be capitalised.
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/cfgroot/graphs.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/cfgroot/graphs.pl b/config/cfgroot/graphs.pl
> index 1bed49fa3..872e9bd7c 100644
> --- a/config/cfgroot/graphs.pl
> +++ b/config/cfgroot/graphs.pl
> @@ -698,7 +698,7 @@ sub updatefwhitsgraph {
> 		"GPRINT:input:AVERAGE:%8.1lf %sBps",
> 		"GPRINT:input:MIN:%8.1lf %sBps",
> 		"GPRINT:input:LAST:%8.1lf %sBps\\j",
> -		"STACK:newnotsyn".$color{"color14"}."A0:".sprintf("%-25s","NewNotSyn"),
> +		"STACK:newnotsyn".$color{"color14"}."A0:".sprintf("%-25s","NewNotSYN"),
> 		"GPRINT:newnotsyn:MAX:%8.1lf %sBps",
> 		"GPRINT:newnotsyn:MIN:%8.1lf %sBps",
> 		"GPRINT:newnotsyn:AVERAGE:%8.1lf %sBps",
> -- 
> 2.16.4


      parent reply	other threads:[~2020-04-27 15:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 15:24 Peter Müller
2020-04-27 15:24 ` [PATCH 2/4] en.pl: " Peter Müller
2020-04-27 15:24   ` [PATCH 3/4] de.pl: mention technical detail regarding new not SYN packets Peter Müller
2020-04-27 15:25     ` [PATCH 4/4] graphs.pl: use brackets instead of hypens Peter Müller
2020-04-27 15:33       ` Michael Tremer
2020-04-27 15:33     ` [PATCH 3/4] de.pl: mention technical detail regarding new not SYN packets Michael Tremer
2020-04-27 15:33   ` [PATCH 2/4] en.pl: fix spelling of "SYN" Michael Tremer
2020-04-27 15:33 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C71BE969-6073-4128-BC14-20DA834C6C9A@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox