Re: [PATCH 0/3] Reworked patches introducing node_exporter on master

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2882 bytes --]

Hello,

> On 24 Jul 2021, at 19:56, Holger Sunke <holger.sunke(a)posteo.de> wrote:
> 
> These are reworked patches on top of [master] that modify the [go] package to be downloaded
> for all supported architectures and introduce the new package [node_exporter], which requires [go]
> during compilation.

Okay, this looks a lot better now, although I have a couple of minor things left. Very minor.

I will respond to the individual emails.

-Michael

> I also added a node_exporter_starter.sh which redirects output into a log file and does not suppress 'loadproc' status output.
> 
> These patches replace my previous patches on node_exporter and go.
> 
> --
> node_exporter generally provides a number of runtime related metrics through a lightweight HTTP plain text interface that can be
> scraped by time series databases in regular interval. These metrics can then be used in grapical UIs for monitoring, analyzation and alerting.
> It is of use for users already monitoring their machines this way and just are about to add their ipfire nodes into the monitoring stack.
> 
> Holger Sunke (3):
>  Added x86_64 i586 aarch64 armv5tel support for GO language required
>    for node_exporter compilation.
>  Added root files aarch64, armv5tel and i586 for 'go'
>  Added new node_exporter 1.2.0 package.
> 
> config/node_exporter/node_exporter_options |   203 +
> config/rootfiles/common/aarch64/go         | 10291 +++++++++++++++++++
> config/rootfiles/common/armv5tel/go        | 10290 ++++++++++++++++++
> config/rootfiles/common/i586/go            | 10290 ++++++++++++++++++
> config/rootfiles/packages/node_exporter    |     4 +
> lfs/Config                                 |     8 +
> lfs/go                                     |     9 +-
> lfs/node_exporter                          |    98 +
> make.sh                                    |     1 +
> src/initscripts/packages/node_exporter     |    39 +
> src/paks/node_exporter/install.sh          |    31 +
> src/paks/node_exporter/uninstall.sh        |    30 +
> src/paks/node_exporter/update.sh           |    27 +
> src/scripts/node_exporter_starter.sh       |     7 +
> 14 files changed, 31325 insertions(+), 3 deletions(-)
> create mode 100644 config/node_exporter/node_exporter_options
> create mode 100644 config/rootfiles/common/aarch64/go
> create mode 100644 config/rootfiles/common/armv5tel/go
> create mode 100644 config/rootfiles/common/i586/go
> create mode 100644 config/rootfiles/packages/node_exporter
> create mode 100644 lfs/node_exporter
> create mode 100644 src/initscripts/packages/node_exporter
> create mode 100644 src/paks/node_exporter/install.sh
> create mode 100644 src/paks/node_exporter/uninstall.sh
> create mode 100644 src/paks/node_exporter/update.sh
> create mode 100644 src/scripts/node_exporter_starter.sh
> 
> -- 
> 2.30.2
>