From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] BUG12301: Iptables =?utf-8?q?=E2=80=9Chost/network_?=
 =?utf-8?b?4oCYbm9uZeKAmSBub3QgZm91bmTigJ0=?=
Date: Thu, 01 Apr 2021 14:21:42 +0100
Message-ID: <CA0A4409-426F-4056-B95D-23168A48F603@ipfire.org>
In-Reply-To: <20210401125044.39919-1-alexander.marx@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2722672183291086876=="
List-Id: <development.lists.ipfire.org>

--===============2722672183291086876==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

The bug report states rules that are generated in a wrong way and could not b=
e inserted.

This patch only changes firewall.cgi. Do we not need to have anything that sk=
ips those rules or would this case just not happen after the files have been =
saved again after this patch?

-Michael

> On 1 Apr 2021, at 13:50, Alexander Marx <alexander.marx(a)ipfire.org> wrote:
>=20
> Fixes: #12301
>=20
> When using hosts with MAC-addresses in a hostgroup,
> the rule won't be generated if those hosts are selected as target.
> There is a hint but due to a wrong hashparameter the hint was not shown.
>=20
> With this patch the hint is shown again.
> ---
> html/cgi-bin/firewall.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
> index 1483e779f..b0851dd3e 100644
> --- a/html/cgi-bin/firewall.cgi
> +++ b/html/cgi-bin/firewall.cgi
> @@ -592,7 +592,7 @@ sub checktarget
> 		&General::readhasharray("$confighost", \%customhost);
> 		foreach my $grpkey (sort keys %customgrp){
> 			foreach my $hostkey (sort keys %customhost){
> -				if ($customgrp{$grpkey}[2] eq $customhost{$hostkey}[0] && $customgrp{$=
grpkey}[2] eq $fwdfwsettings{$fwdfwsettings{'grp2'}} && $customhost{$hostkey}=
[1] eq 'mac'){
> +				if ($customgrp{$grpkey}[2] eq $customhost{$hostkey}[0] && $customgrp{$=
grpkey}[0] eq $fwdfwsettings{$fwdfwsettings{'grp2'}} && $customhost{$hostkey}=
[1] eq 'mac'){
> 					$hint=3D$Lang::tr{'fwdfw hint mac'};
> 					return $hint;
> 				}
> --=20
> 2.25.1
>=20


--===============2722672183291086876==--