From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: The unshared changes give a problem with build after doing git
 pull on next
Date: Thu, 29 Aug 2024 09:39:47 +0200
Message-ID: <CB260BA6-4A2F-425A-8FAF-C467D7704955@ipfire.org>
In-Reply-To: <f583b48c-6677-4625-9181-136900c269da@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3116015122842743052=="
List-Id: <development.lists.ipfire.org>

--===============3116015122842743052==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 28 Aug 2024, at 18:30, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> On 28.08.2024 17:46, Michael Tremer wrote:
>> Hello everyone,
>=20
> Hi,
>=20
>> Could you please confirm that this works:
>>=20
>>  https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D5e8730eb9ae=
c83a76b3ae7719925ede8470069a6
>=20
> For me it does.
>=20
>> It works for me on Ubuntu 22.04 LTS with kernel 5.15.
>=20
> Here:
> Ubuntu 22.04 LTS / 6.8.0-40-generic

This is kind of the wrong kernel, but at least it didn=E2=80=99t break anythi=
ng either :)

> I tested 'make.sh' with all important parameters (clean, downloadsrc,
> gettoolchain) - right now a 'next'-build is running and looking good -
> I'll report when its ready. ;-)
>=20
> Best
> Matthias
>=20
>> There is also another fix to support kernels without time namespaces (< 5.=
6). However, I am not sure if the built itself runs through on this and does =
not require anything more recent:
>>=20
>>  https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3Dfaccfa70754=
fabaed56c9147ace4d509f7d2317c
>>=20
>> -Michael
>>=20
>>> On 27 Aug 2024, at 20:03, / / <siosios1(a)hotmail.com> wrote:
>>>=20
>>> I can concur that moving the line to where Matthias put it does fix the i=
ssues on my machines with downloading and building, it also takes care of the=
 error ->  mount: /git/ipfire-2.x/build_x86_64/proc: mount point does not exi=
st from what I am seeing.
>>>=20
>>> # If unshare is asked to terminate, terminate all child processes
>>>  "--kill-child"
>>> )
>>>=20
>>> mount --bind ${BUILD_DIR}/proc ${BUILD_DIR}/proc
>>>=20
>>> fi
>>>=20
>>> while [ $# -gt 0 ]; do
>>>=20
>>> one thing I don't see is the mount when i check the output of mount or th=
e output of findmnt -o+PROPAGATION
>>=20
>=20


--===============3116015122842743052==--