From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] zoneconf: reduce the width of inputs for vlanid
Date: Thu, 05 Sep 2019 10:33:36 +0100
Message-ID: <CB3107AC-931F-423B-90FC-A8EDBA41AF62@ipfire.org>
In-Reply-To: <d3e12b3e-ecbd-5930-07aa-a6ec8ea3ec4a@starkstromkonsument.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4778230679628479705=="
List-Id: <development.lists.ipfire.org>

--===============4778230679628479705==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 3 Sep 2019, at 19:50, Alexander Koch <ipfire(a)starkstromkonsument.de> w=
rote:
>=20
> Hi,
>=20
> the Problem occurs if you use four zones and the "ipfire-legacy"-Theme. But=
 the "ipfire"-Theme also renders the vlanid-input pretty wide and wraps the l=
ine inside the cell. There actually is no need for this, as an VLAN-ID has a =
maximum length of four digits.
>=20
> Some Screenshots: https://starkstromlahn.spdns.org/s/qb4iFZmxCQqxb7f

The old theme is practically unmaintainable, but good to take a little bit of=
 care here as well.

Acked-by: Michael Tremer <michael.tremer(a)ipfire.org>

-Michael

>=20
> Regards, Alex
>=20
>=20
> -------- Original Message --------
> From: Michael Tremer [mailto:michael.tremer(a)ipfire.org]
> Sent: Monday, 2 September 2019, 13:32 CEST
> To: Alex Koch <ipfire(a)starkstromkonsument.de>
> Cc: development(a)lists.ipfire.org
> Subject: [PATCH] zoneconf: reduce the width of inputs for vlanid
>=20
> Hi,
>=20
> Just for my own illustration, could you send a screenshot?
>=20
> Best,
> -Michael
>=20
> On 1 Sep 2019, at 23:47, Alex Koch <ipfire(a)starkstromkonsument.de> wrote:
>=20
> The inputs for the vlanids are overlapping the borders of their cells (usin=
g a recent Firefox on Linux Mint, Android or Windows 7). This patch fixes thi=
s by limiting the width to a fixed value.
>=20
> Signed-off-by: Alex Koch <ipfire(a)starkstromkonsument.de>
> ---
> html/cgi-bin/zoneconf.cgi | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/zoneconf.cgi b/html/cgi-bin/zoneconf.cgi
> index 40239c14e..6b8642818 100644
> --- a/html/cgi-bin/zoneconf.cgi
> +++ b/html/cgi-bin/zoneconf.cgi
> @@ -93,6 +93,10 @@ my $css =3D <<END
> 		text-align: center;
> 	}
>=20
> +	input.vlanid {
> +		width: 4em;
> +	}
> +
> 	#submit-container {
> 		width: 100%;
> 		padding-top: 20px;
> @@ -432,7 +436,7 @@ foreach (@nics) {
> 					<option value=3D"NATIVE" $access_selected{"NATIVE"}>$Lang::tr{"zonecon=
f access native"}</option>
> 					<option value=3D"VLAN" $access_selected{"VLAN"} $vlan_disabled>$Lang::=
tr{"zoneconf access vlan"}</option>
> 				</select>
> -				<input type=3D"number" id=3D"TAG $uc $mac" name=3D"TAG $uc $mac" min=
=3D"1" max=3D"4095" value=3D"$zone_vlan_id" $field_disabled>
> +				<input type=3D"number" class=3D"vlanid" id=3D"TAG $uc $mac" name=3D"TA=
G $uc $mac" min=3D"1" max=3D"4095" value=3D"$zone_vlan_id" $field_disabled>
> 			</td>
> END
> ;
> --=20
> 2.17.1
>=20
>=20
>=20


--===============4778230679628479705==--