From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH 1/2] lm_sensors: Update to 3-6-0 Date: Fri, 16 Apr 2021 11:34:00 +0100 Message-ID: In-Reply-To: <0a77772e-5121-35cc-256f-c3a698ddb781@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1024856642492577519==" List-Id: --===============1024856642492577519== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable > On 15 Apr 2021, at 12:42, Adolf Belka wrote: >=20 > Hi Michael, >=20 > On 15/04/2021 12:36, Michael Tremer wrote: >> Hello, >>> On 14 Apr 2021, at 21:02, Adolf Belka wrote: >>>=20 >>> Hi Michael, >>>=20 >>> On 14/04/2021 19:48, Michael Tremer wrote: >>>> Hello, >>>> There was another sobump in this package and netsnmpd was linking agains= t it. >>>> I incremented the release number of that package, too. >>> Ah, so if a shared object library is changed in the rootfiles by an updat= e I should run the find-dependencies step to see if there are any other addon= programs linked to it, in which case I need to increment the PAK_VER number = of that package as well and submit as a patch. >> Not always, but sometimes :) >> Every binary has a lost of libraries that it needs. Those are what we call= =E2=80=9Cdependencies=E2=80=9D. You can see them by using =E2=80=9Creadelf -= d=E2=80=9D (the NEEDED lines): >> root(a)michael:/build/ipfire-2.x# readelf -d /bin/bash >> Dynamic section at offset 0x113cf0 contains 28 entries: >> Tag Type Name/Value >> 0x0000000000000001 (NEEDED) Shared library: [libtinfo.so.6] >> 0x0000000000000001 (NEEDED) Shared library: [libdl.so.2] >> 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] >> 0x000000000000000c (INIT) 0x2d000 >> 0x000000000000000d (FINI) 0xda784 >> 0x0000000000000019 (INIT_ARRAY) 0x1123f0 >> But instead of listing "libtinfo.so.6.1=E2=80=9D, only the first number is= included. >> That is so that you can update a library if bugs have been fixed and give = it a new version (libtinfo.so.6.2, libtinfo.so.6.3, libtinfo.so.6.4, =E2=80= =A6) and avoid recompiling all programs. Most of the time, nothing important = changes, only what a function does might be slightly changed, which is not re= ally relevant to =E2=80=9Cbash=E2=80=9D in this case. >> The runtime linker is now looking for =E2=80=9Clibtinfo.so.6=E2=80=9D whic= h is a symlink to libtinfo.so.6.1. >> If libtinfo.so.6 disappears because an update to libtinfo.so.7 would be in= stalled, bash will no longer function because the runtime linker does not fin= d all needed libraries. >> That is why we need to find all files that are linked against a library if= we move from .6 to .7, but not when we move from .6.1 to .6.2. >> I hope this makes sense :) > Absolutely. Thanks for the explanation. It makes sense to me now. Also why = there are so.x and so.x.y library files and the way they are symlinked. That = now makes sense to me. >=20 > Always something new to learn. Thanks very much Happy to help :) >=20 > Adolf. >>> Just to confirm that is only if another addon is flagged. What if a commo= n program is flagged, how do I deal with that because they don't have a PAK_V= ER to increment? >> Then we would need to ship those programs by linking the root files into t= he core update. >> -Michael >>>=20 >>> Regards, >>> Adolf >>>=20 >>>> Best, >>>> -Michael >>>>> On 14 Apr 2021, at 12:57, Adolf Belka wrote: >>>>>=20 >>>>> - Update from 3-4-0 to 3-6-0 >>>>> - Update of rootfilers in each architecture >>>>> Only the library version changed in each rootfile >>>>> - Installed updated lm_sensors. Confirmed updated version was installed. >>>>> sensors-detect ran successfully but could not confirm successful sens= or >>>>> detection as installation was run on vm testbed and this has no sesno= rs >>>>> Testing on real hardware to confirm that sensors are detected and >>>>> sensor-* directories correctly created in IPFire. >>>>> - Changelog >>>>> 3.6.0 (2019-10-18) >>>>> configs: Added a number of new configuration files >>>>> fancontrol: AVERAGE env variable can be used to set the number of p= revi> >>>>> Makefile: The MACHINE variable has been renamed to ARCH >>>>> sensord: Add an option -1/--oneline to print chip and adapter on th= e sa> >>>>> sensors: Fixed a stray comma bug in the JSON output >>>>> Fixed Fahrenheit conversion with raw and JSON output >>>>> Scale voltage and current values in the default output for= mat >>>>> sensors-detect: Add detection of AMD Family 17h, models 30h, 70h >>>>> Add detection of some AMD Family 15h models >>>>> Add detection of AMD Family 16h model 30h power sen= sors >>>>> Add detection of Hygon Family 18h thermal sensors >>>>> Add detection of Nuvoton NCT6797D >>>>> Add detection of Nuvoton NCT6798D >>>>> Add detection of Nuvoton NCT6112D/NCT6114D/NCT6116D >>>>> Fix printing CPU info on non-x86 arches >>>>> Fix printing lm_sensors version >>>>> Mark Fintek F75387SG/RG as supported by the f75375s= dri> >>>>> 3.5.0 (2018-11-23) >>>>> Fixed disappearance of certain hwmon chips with 4.19+ kernels >>>>> Add the find-driver script for debugging >>>>> Various documentation and man page improvements >>>>> Fix various issues found by Coverity Scan >>>>> Fix compilation with the musl C library >>>>> Development version string now contains "+git" instead of "+SVN" >>>>> Updated links in documentation to reflect the new home of lm_sensors >>>>> sensors.1: Add reference to sensors-detect >>>>> Document -j option (json output) >>>>> sensors: Add support for json output >>>>> Add support for power min, lcrit, min_alarm, lcrit_alarm >>>>> sensors-detect: Fix systemd paths >>>>> Add detection of Fintek F81768 >>>>> Only probe I/O ports on x86 >>>>> Add detection of Nuvoton NCT6793D >>>>> Add detection of Microchip MCP9808 >>>>> Mark F71868A as supported by the f71882fg driver >>>>> Mark F81768D as supported by the f71882fg driver >>>>> Mark F81866D as supported by the f71882fg driver >>>>> Add detection of various ITE chips >>>>> Add detection of Nuvoton NCT6795D >>>>> Add detection of DDR4 SPD >>>>> Add detection of ITE IT8987D >>>>> Add detection of AMD Family 17h temperature sensors >>>>> Add detection of AMD KERNCZ SMBus controller >>>>> Add detection of various Intel SMBus controllers >>>>> Add detection of Giantec GT30TS00 >>>>> Add detection of ONS CAT34TS02C and CAT34TS04 >>>>> Add detection of AMD Family 15h Model 60+ temperatu= re s> >>>>> Add detection of Nuvoton NCT6796D >>>>> Add detection of AMD Family 15h Model 70+ temperatu= re s> >>>>> configs: Add sample configuration files. >>>>> sensors.conf.default: Add hardwired inputs of NCT6795D >>>>> Add hardwired inputs of F71868A >>>>> Add hardwired NCT6796D inputs >>>>> vt1211_pwm: replaced deprecated sub shell syntax >>>>> run with bash instead of sh >>>>> pwmconfig: replaced deprecated sub shell syntax >>>>> fancontrol: replaced deprecated sub shell syntax >>>>> save original pwm values >>>>> fancontrol.8: replaced deprecated sub shell syntax >>>>> libsensors: Add support for SENSORS_BUS_TYPE_SCSI >>>>> Add support for power min, lcrit, min_alarm, lcrit_alarm >>>>>=20 >>>>> Signed-off-by: Adolf Belka >>>>> --- >>>>> config/rootfiles/common/aarch64/lm_sensors | 4 ++-- >>>>> config/rootfiles/common/armv5tel/lm_sensors | 4 ++-- >>>>> config/rootfiles/common/i586/lm_sensors | 4 ++-- >>>>> config/rootfiles/common/x86_64/lm_sensors | 4 ++-- >>>>> lfs/lm_sensors | 10 +++++----- >>>>> 5 files changed, 13 insertions(+), 13 deletions(-) >>>>>=20 >>>>> diff --git a/config/rootfiles/common/aarch64/lm_sensors b/config/rootfi= les/common/aarch64/lm_sensors >>>>> index 1346047b9..f10ad80bd 100644 >>>>> --- a/config/rootfiles/common/aarch64/lm_sensors >>>>> +++ b/config/rootfiles/common/aarch64/lm_sensors >>>>> @@ -7,8 +7,8 @@ usr/bin/sensors-conf-convert >>>>> #usr/include/sensors/sensors.h >>>>> #usr/lib/libsensors.a >>>>> #usr/lib/libsensors.so >>>>> -usr/lib/libsensors.so.4 >>>>> -usr/lib/libsensors.so.4.4.0 >>>>> +usr/lib/libsensors.so.5 >>>>> +usr/lib/libsensors.so.5.0.0 >>>>> #usr/man/man1/sensors.1 >>>>> #usr/man/man3/libsensors.3 >>>>> #usr/man/man5/sensors.conf.5 >>>>> diff --git a/config/rootfiles/common/armv5tel/lm_sensors b/config/rootf= iles/common/armv5tel/lm_sensors >>>>> index 998b02e9f..52514f1ab 100644 >>>>> --- a/config/rootfiles/common/armv5tel/lm_sensors >>>>> +++ b/config/rootfiles/common/armv5tel/lm_sensors >>>>> @@ -7,8 +7,8 @@ usr/bin/sensors-conf-convert >>>>> #usr/include/sensors/sensors.h >>>>> #usr/lib/libsensors.a >>>>> usr/lib/libsensors.so >>>>> -usr/lib/libsensors.so.4 >>>>> -usr/lib/libsensors.so.4.4.0 >>>>> +usr/lib/libsensors.so.5 >>>>> +usr/lib/libsensors.so.5.0.0 >>>>> #usr/man/man1/sensors.1 >>>>> #usr/man/man3/libsensors.3 >>>>> #usr/man/man5/sensors.conf.5 >>>>> diff --git a/config/rootfiles/common/i586/lm_sensors b/config/rootfiles= /common/i586/lm_sensors >>>>> index 9936e0466..0f7461d4c 100644 >>>>> --- a/config/rootfiles/common/i586/lm_sensors >>>>> +++ b/config/rootfiles/common/i586/lm_sensors >>>>> @@ -7,8 +7,8 @@ usr/bin/sensors-conf-convert >>>>> #usr/include/sensors/sensors.h >>>>> #usr/lib/libsensors.a >>>>> usr/lib/libsensors.so >>>>> -usr/lib/libsensors.so.4 >>>>> -usr/lib/libsensors.so.4.4.0 >>>>> +usr/lib/libsensors.so.5 >>>>> +usr/lib/libsensors.so.5.0.0 >>>>> #usr/man/man1/sensors.1 >>>>> #usr/man/man3/libsensors.3 >>>>> #usr/man/man5/sensors.conf.5 >>>>> diff --git a/config/rootfiles/common/x86_64/lm_sensors b/config/rootfil= es/common/x86_64/lm_sensors >>>>> index 9936e0466..0f7461d4c 100644 >>>>> --- a/config/rootfiles/common/x86_64/lm_sensors >>>>> +++ b/config/rootfiles/common/x86_64/lm_sensors >>>>> @@ -7,8 +7,8 @@ usr/bin/sensors-conf-convert >>>>> #usr/include/sensors/sensors.h >>>>> #usr/lib/libsensors.a >>>>> usr/lib/libsensors.so >>>>> -usr/lib/libsensors.so.4 >>>>> -usr/lib/libsensors.so.4.4.0 >>>>> +usr/lib/libsensors.so.5 >>>>> +usr/lib/libsensors.so.5.0.0 >>>>> #usr/man/man1/sensors.1 >>>>> #usr/man/man3/libsensors.3 >>>>> #usr/man/man5/sensors.conf.5 >>>>> diff --git a/lfs/lm_sensors b/lfs/lm_sensors >>>>> index 8403be6e0..42c55d6d6 100644 >>>>> --- a/lfs/lm_sensors >>>>> +++ b/lfs/lm_sensors >>>>> @@ -24,10 +24,10 @@ >>>>>=20 >>>>> include Config >>>>>=20 >>>>> -VER =3D 3.4.0 >>>>> +VER =3D 3-6-0 >>>>>=20 >>>>> -THISAPP =3D lm_sensors-$(VER) >>>>> -DL_FILE =3D $(THISAPP).tar.bz2 >>>>> +THISAPP =3D lm-sensors-$(VER) >>>>> +DL_FILE =3D $(THISAPP).tar.gz >>>>> DL_FROM =3D $(URL_IPFIRE) >>>>> DIR_APP =3D $(DIR_SRC)/$(THISAPP) >>>>> TARGET =3D $(DIR_INFO)/$(THISAPP) >>>>> @@ -40,7 +40,7 @@ objects =3D $(DL_FILE) >>>>>=20 >>>>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >>>>>=20 >>>>> -$(DL_FILE)_MD5 =3D c03675ae9d43d60322110c679416901a >>>>> +$(DL_FILE)_MD5 =3D f60e47b5eb50bbeed48a9f43bb08dd5e >>>>>=20 >>>>> install : $(TARGET) >>>>>=20 >>>>> @@ -72,7 +72,7 @@ $(subst %,%_MD5,$(objects)) : >>>>>=20 >>>>> $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >>>>> @$(PREBUILD) >>>>> - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar jxf $(DIR_DL)/$(DL_FILE) >>>>> + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) >>>>> cd $(DIR_APP) && make PREFIX=3D/usr $(MAKETUNING) >>>>> cd $(DIR_APP) && make PREFIX=3D/usr install >>>>> @rm -rf $(DIR_APP) >>>>> --=20 >>>>> 2.31.1 >>>>>=20 >=20 > --=20 > Sent from my laptop --===============1024856642492577519==--