Re: [PATCH] Nano: Move nano editor from packages to core system

[Jon Murphy <jcmurphy26@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3456 bytes --]

Hey Peter!

This is my first patch so I am looking to learn!  (See below)


> On Mar 21, 2022, at 2:06 PM, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Hello *,
> 
> I just merged this patch into next, but since it was generated manually, I had to do
> the changes introduced by it myself manually.

Did I create the patch incorrectly?  Is there something I can do differently?

> 
>> Hello,
>> 
>> I personally do not count nano as an editor. There are so many things wrong with it :)
>> 
>> But if everyone wants this, I do not think that shipping ~444 KB of code will break the camel’s back.
> 
> Certainly not.
> 
>> 
>> Acked-by: Michael Tremer <michael.tremer(a)ipfire.org>
>> 
>> -Michael
>> 
>> P.S. @Peter: Would you please make sure that pakfire drops the metadata of the package?

Same with this question - Is there something I can do differently?

> 
> Yes.
> 
> Thanks, and best regards,
> Peter Müller

Thank you!
Jon

> 
>> 
>>> On 21 Mar 2022, at 17:49, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi All,
>>> 
>>> On 21/03/2022 17:22, Peter Müller wrote:
>>>> Hello *,
>>>> 
>>>>> Hello,
>>>>> 
>>>>> How is everybody feeling about this?
>>>> I understand the motivation behind this. In my early days, I completely lacked any vim
>>>> skills, and found it pretty stressing to bring things back up after a crash while at the
>>>> same time frantically thinking "how to %&§#$ deal with this text editor?!".
>>>> 
>>>>> How many nano users do we have here?
>>> I am definitely one. I also use nano for working on my Arch Linux systems and adjust the default editor for things like visudo so it uses nano.
>>> 
>>> 
>>> Regards,
>>> Adolf.
>>>> Back then, nano would have helped me. Today, I am used to vim and would not experience
>>>> any benefit from nano being around on IPFire as well.
>>>> 
>>>> Nevertheless, I vote in favour of this patch, for reasons mentioned above.
>>>> 
>>>> Acked-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>> 
>>>> Thanks, and best regards,
>>>> Peter Müller
>>>> 
>>>>> -Michael
>>>>> 
>>>>>> On 17 Mar 2022, at 17:06, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
>>>>>> 
>>>>>> - this will not change the default editor `vim`
>>>>>> 
>>>>>> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
>>>>>> ---
>>>>>> config/rootfiles/{packages => common}/nano | 0
>>>>>> lfs/nano                                   | 7 +++----
>>>>>> 2 files changed, 3 insertions(+), 4 deletions(-)
>>>>>> rename config/rootfiles/{packages => common}/nano (100%)
>>>>>> 
>>>>>> diff --git a/config/rootfiles/packages/nano b/config/rootfiles/common/nano
>>>>>> similarity index 100%
>>>>>> rename from config/rootfiles/packages/nano
>>>>>> rename to config/rootfiles/common/nano
>>>>>> diff --git a/lfs/nano b/lfs/nano
>>>>>> index df994364f..85be014ee 100644
>>>>>> --- a/lfs/nano
>>>>>> +++ b/lfs/nano
>>>>>> @@ -32,12 +32,11 @@ DL_FILE    = $(THISAPP).tar.xz
>>>>>> DL_FROM    = $(URL_IPFIRE)
>>>>>> DIR_APP    = $(DIR_SRC)/$(THISAPP)
>>>>>> TARGET     = $(DIR_INFO)/$(THISAPP)
>>>>>> -PROG       = nano
>>>>>> -PAK_VER    = 41
>>>>>> 
>>>>>> -DEPS       = ""
>>>>>> 
>>>>>> -SERVICES   =
>>>>>> 
>>>>>> ###############################################################################
>>>>>> # Top-level Rules
>>>>>> -- 
>>>>>> 2.30.2
>>>>>> 
>>> 
>>> -- 
>>> Sent from my laptop
>>