From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Murphy To: development@lists.ipfire.org Subject: Re: [PATCH] Nano: Move nano editor from packages to core system Date: Mon, 21 Mar 2022 16:20:26 -0500 Message-ID: In-Reply-To: <2cd3278b-bbee-c1fd-5790-4732cc12fe2f@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4478108494241896584==" List-Id: --===============4478108494241896584== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hey Peter! This is my first patch so I am looking to learn! (See below) > On Mar 21, 2022, at 2:06 PM, Peter M=C3=BCller = wrote: >=20 > Hello *, >=20 > I just merged this patch into next, but since it was generated manually, I = had to do > the changes introduced by it myself manually. Did I create the patch incorrectly? Is there something I can do differently? >=20 >> Hello, >>=20 >> I personally do not count nano as an editor. There are so many things wron= g with it :) >>=20 >> But if everyone wants this, I do not think that shipping ~444 KB of code w= ill break the camel=E2=80=99s back. >=20 > Certainly not. >=20 >>=20 >> Acked-by: Michael Tremer >>=20 >> -Michael >>=20 >> P.S. @Peter: Would you please make sure that pakfire drops the metadata of= the package? Same with this question - Is there something I can do differently? >=20 > Yes. >=20 > Thanks, and best regards, > Peter M=C3=BCller Thank you! Jon >=20 >>=20 >>> On 21 Mar 2022, at 17:49, Adolf Belka wrote: >>>=20 >>> Hi All, >>>=20 >>> On 21/03/2022 17:22, Peter M=C3=BCller wrote: >>>> Hello *, >>>>=20 >>>>> Hello, >>>>>=20 >>>>> How is everybody feeling about this? >>>> I understand the motivation behind this. In my early days, I completely = lacked any vim >>>> skills, and found it pretty stressing to bring things back up after a cr= ash while at the >>>> same time frantically thinking "how to %&=C2=A7#$ deal with this text ed= itor?!". >>>>=20 >>>>> How many nano users do we have here? >>> I am definitely one. I also use nano for working on my Arch Linux systems= and adjust the default editor for things like visudo so it uses nano. >>>=20 >>>=20 >>> Regards, >>> Adolf. >>>> Back then, nano would have helped me. Today, I am used to vim and would = not experience >>>> any benefit from nano being around on IPFire as well. >>>>=20 >>>> Nevertheless, I vote in favour of this patch, for reasons mentioned abov= e. >>>>=20 >>>> Acked-by: Peter M=C3=BCller >>>>=20 >>>> Thanks, and best regards, >>>> Peter M=C3=BCller >>>>=20 >>>>> -Michael >>>>>=20 >>>>>> On 17 Mar 2022, at 17:06, Jon Murphy wrote: >>>>>>=20 >>>>>> - this will not change the default editor `vim` >>>>>>=20 >>>>>> Signed-off-by: Jon Murphy >>>>>> --- >>>>>> config/rootfiles/{packages =3D> common}/nano | 0 >>>>>> lfs/nano | 7 +++---- >>>>>> 2 files changed, 3 insertions(+), 4 deletions(-) >>>>>> rename config/rootfiles/{packages =3D> common}/nano (100%) >>>>>>=20 >>>>>> diff --git a/config/rootfiles/packages/nano b/config/rootfiles/common/= nano >>>>>> similarity index 100% >>>>>> rename from config/rootfiles/packages/nano >>>>>> rename to config/rootfiles/common/nano >>>>>> diff --git a/lfs/nano b/lfs/nano >>>>>> index df994364f..85be014ee 100644 >>>>>> --- a/lfs/nano >>>>>> +++ b/lfs/nano >>>>>> @@ -32,12 +32,11 @@ DL_FILE =3D $(THISAPP).tar.xz >>>>>> DL_FROM =3D $(URL_IPFIRE) >>>>>> DIR_APP =3D $(DIR_SRC)/$(THISAPP) >>>>>> TARGET =3D $(DIR_INFO)/$(THISAPP) >>>>>> -PROG =3D nano >>>>>> -PAK_VER =3D 41 >>>>>>=20 >>>>>> -DEPS =3D "" >>>>>>=20 >>>>>> -SERVICES =3D >>>>>>=20 >>>>>> ######################################################################= ######### >>>>>> # Top-level Rules >>>>>> --=20 >>>>>> 2.30.2 >>>>>>=20 >>>=20 >>> --=20 >>> Sent from my laptop >>=20 --===============4478108494241896584==--