Re: [PATCH] update-ipblocklists: remove "<INFO> Skipping" log entries

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]

Hello Jon,

Why should this not be logged?

-Michael

> On 4 Jun 2024, at 21:22, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
> 
> - Remove two <INFO> log entries from message log.
> 
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
> src/scripts/update-ipblocklists | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/scripts/update-ipblocklists b/src/scripts/update-ipblocklists
> index a17b47999..dddde8d27 100644
> --- a/src/scripts/update-ipblocklists
> +++ b/src/scripts/update-ipblocklists
> @@ -86,7 +86,7 @@ foreach my $blocklist (@blocklists) {
> # Check if enough time has passed since the last download of the list.
> if ($time <= $holdoff_time) {
> # To frequent updates, log to syslog.
> - &_log_to_syslog("<INFO> Skipping $blocklist blocklist - Too frequent update attempts!");
> + # &_log_to_syslog("<INFO> Skipping $blocklist blocklist - Too frequent update attempts!");
> 
> # Skip this provider.
> next;
> @@ -100,7 +100,7 @@ foreach my $blocklist (@blocklists) {
> # Handle different return codes.
> if ($return eq "not_modified") {
> # Log notice to syslog.
> - &_log_to_syslog("<INFO> Skipping $blocklist blocklist - It has not been modified!");
> + # &_log_to_syslog("<INFO> Skipping $blocklist blocklist - It has not been modified!");
> } elsif ($return eq "dl_error") {
> # Log error to the syslog.
> &_log_to_syslog("<ERROR> Could not update $blocklist blocklist - Download error\!");
> -- 
> 2.30.2
>