From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] update-ipblocklists: remove "<INFO> Skipping" log entries
Date: Wed, 05 Jun 2024 10:28:13 +0100
Message-ID: <CD9A7252-72E1-4F4E-B1EB-FECE59C0F7E5@ipfire.org>
In-Reply-To: <20240604202253.3546966-1-jon.murphy@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0429910923999986381=="
List-Id: <development.lists.ipfire.org>

--===============0429910923999986381==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Jon,

Why should this not be logged?

-Michael

> On 4 Jun 2024, at 21:22, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
>=20
> - Remove two <INFO> log entries from message log.
>=20
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
> src/scripts/update-ipblocklists | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/src/scripts/update-ipblocklists b/src/scripts/update-ipblockli=
sts
> index a17b47999..dddde8d27 100644
> --- a/src/scripts/update-ipblocklists
> +++ b/src/scripts/update-ipblocklists
> @@ -86,7 +86,7 @@ foreach my $blocklist (@blocklists) {
> # Check if enough time has passed since the last download of the list.
> if ($time <=3D $holdoff_time) {
> # To frequent updates, log to syslog.
> - &_log_to_syslog("<INFO> Skipping $blocklist blocklist - Too frequent upda=
te attempts!");
> + # &_log_to_syslog("<INFO> Skipping $blocklist blocklist - Too frequent up=
date attempts!");
>=20
> # Skip this provider.
> next;
> @@ -100,7 +100,7 @@ foreach my $blocklist (@blocklists) {
> # Handle different return codes.
> if ($return eq "not_modified") {
> # Log notice to syslog.
> - &_log_to_syslog("<INFO> Skipping $blocklist blocklist - It has not been m=
odified!");
> + # &_log_to_syslog("<INFO> Skipping $blocklist blocklist - It has not been=
 modified!");
> } elsif ($return eq "dl_error") {
> # Log error to the syslog.
> &_log_to_syslog("<ERROR> Could not update $blocklist blocklist - Download e=
rror\!");
> --=20
> 2.30.2
>=20


--===============0429910923999986381==--