From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: work in progress: ppp 2.4.9
Date: Thu, 01 Apr 2021 17:41:22 +0100
Message-ID: <CF3139D4-3362-4C41-AC37-CE78A79151D8@ipfire.org>
In-Reply-To: <0307d85d-c5aa-5f7c-eaa3-7bb2f9ba668a@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0459990656133520735=="
List-Id: <development.lists.ipfire.org>

--===============0459990656133520735==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It looks like you are shaving off their own CFLAGS.

Are you passing them to make? Maybe try their configure script.

-Michael

> On 1 Apr 2021, at 17:34, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wro=
te:
>=20
> Hello Michael,
> hello *,
>=20
> yes, and this is certainly a good sign in terms of security. :-)
>=20
> Some of these patches are indeed not necessary anymore, but the majority st=
ill is.
>=20
> However, compiling ppp 2.4.9 fails since it does not find its own libraries=
 included:
>=20
>> make[2]: Entering directory '/usr/src/ppp-2.4.9/pppd/plugins'
>> make[2]: warning: -jN forced in submake: disabling jobserver mode.
>> gcc -o minconn.so  -shared -O2 -pipe -Wall -fexceptions -fPIC -m64 -mtune=
=3Dgeneric -fstack-clash-protection -fcf-protection -Wp,-D_FORTIFY_SOURCE=3D2=
 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fno-strict-aliasing minc=
onn.c
>> gcc -o passprompt.so  -shared -O2 -pipe -Wall -fexceptions -fPIC -m64 -mtu=
ne=3Dgeneric -fstack-clash-protection -fcf-protection -Wp,-D_FORTIFY_SOURCE=
=3D2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fno-strict-aliasing =
passprompt.c
>> gcc -o passwordfd.so  -shared -O2 -pipe -Wall -fexceptions -fPIC -m64 -mtu=
ne=3Dgeneric -fstack-clash-protection -fcf-protection -Wp,-D_FORTIFY_SOURCE=
=3D2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fno-strict-aliasing =
passwordfd.c
>> gcc -o winbind.so  -shared -O2 -pipe -Wall -fexceptions -fPIC -m64 -mtune=
=3Dgeneric -fstack-clash-protection -fcf-protection -Wp,-D_FORTIFY_SOURCE=3D2=
 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fno-strict-aliasing winb=
ind.c
>> minconn.c:37:10: fatal error: pppd.h: No such file or directory
>>   37 | #include "pppd.h"
>>      |          ^~~~~~~~
>> compilation terminated.
>> make[2]: *** [Makefile:38: minconn.so] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> passprompt.c:15:10: fatal error: pppd.h: No such file or directory
>>   15 | #include "pppd.h"
>>      |          ^~~~~~~~
>> compilation terminated.
>> make[2]: *** [Makefile:38: passprompt.so] Error 1
>> winbind.c:37:10: fatal error: pppd.h: No such file or directory
>>   37 | #include "pppd.h"
>>      |          ^~~~~~~~
>> compilation terminated.
>> passwordfd.c:15:10: fatal error: pppd.h: No such file or directory
>>   15 | #include "pppd.h"
>>      |          ^~~~~~~~
>> compilation terminated.
>> make[2]: *** [Makefile:38: winbind.so] Error 1
>> make[2]: *** [Makefile:38: passwordfd.so] Error 1
>> make[2]: Leaving directory '/usr/src/ppp-2.4.9/pppd/plugins'
>> make[1]: *** [Makefile:14: all] Error 2
>> make[1]: Leaving directory '/usr/src/ppp-2.4.9'
>> make: *** [ppp:83: /usr/src/log/ppp-2.4.9] Error 2
>=20
> Since I never experienced the need to fix something like this for IPFire, I=
 am a bit
> unsure what the projects' convention says in this case. Passing these direc=
tories via
> the CFLAGS ("-I /usr/src/ppp-2.4.9/") seems ugly to me.
>=20
> What do we do in this case? :-)
>=20
> Thanks, and best regards,
> Peter M=C3=BCller
>=20
>> Hello,
>>=20
>> It seems that a new maintainer has taken over pppd and started with mergin=
g many upstream patches that various distributions have been carrying around =
with them for a long time.
>>=20
>> All patches currently in next are security stuff and no functionality. It =
might not be bad if this patch does not apply exactly if the new maintainer(s=
) found a different solution.
>>=20
>> I believe some of the patches are rather hacky.
>>=20
>> Best,
>> -Michael
>>=20
>>> On 31 Mar 2021, at 18:01, Peter M=C3=BCller <peter.mueller(a)ipfire.org> =
wrote:
>>>=20
>>> Hello development folks,
>>>=20
>>> for your information: I am currently working on ppp 2.4.9, which turns ou=
t to be rather
>>> tricky as many of our patches won't apply and/or are not necessary anymor=
e.
>>>=20
>>> Thanks, and best regards,
>>> Peter M=C3=BCller
>>=20


--===============0459990656133520735==--