From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: Fix max-clients option
Date: Mon, 04 Nov 2019 16:32:32 +0000
Message-ID: <CF7EF2BF-4594-4673-9F3D-EECDA9BA714B@ipfire.org>
In-Reply-To: <20191104145226.19638-1-ummeegge@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8623965269641625384=="
List-Id: <development.lists.ipfire.org>

--===============8623965269641625384==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

Interesting is how long this has been in here unnoticed.

> On 4 Nov 2019, at 14:52, Erik Kapfer <ummeegge(a)ipfire.org> wrote:
>=20
> Fix: Triggered by https://forum.ipfire.org/viewtopic.php?f=3D16&t=3D23551
>=20
> Since the 'DHCP_WINS' cgiparam has been set for the max-client directive, c=
hanges in the WUI has not been adapted to server.conf.
>=20
> Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
> ---
> html/cgi-bin/ovpnmain.cgi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 970444a55..09f0dc42f 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -355,10 +355,10 @@ sub writeserverconf {
>         print CONF "push \"dhcp-option WINS $sovpnsettings{DHCP_WINS}\"\n";
>     }
>=20
> -    if ($sovpnsettings{DHCP_WINS} eq '') {
> +    if ($sovpnsettings{MAX_CLIENTS} eq '') {
> 	print CONF "max-clients 100\n";
>     }
> -    if ($sovpnsettings{DHCP_WINS} ne '') {
> +    if ($sovpnsettings{MAX_CLIENTS} ne '') {
> 	print CONF "max-clients $sovpnsettings{MAX_CLIENTS}\n";
>     }=09
>     print CONF "tls-verify /usr/lib/openvpn/verify\n";
> --=20
> 2.12.2
>=20


--===============8623965269641625384==--