From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: libloc 0.9.16 rootfile changes
Date: Mon, 21 Nov 2022 14:23:55 +0000
Message-ID: <D094821E-E9D9-40F1-9C36-176361CBC4BA@ipfire.org>
In-Reply-To: <0fcd2e8e-7264-79ef-e247-8cabf96d5ce4@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8592575333329255895=="
List-Id: <development.lists.ipfire.org>

--===============8592575333329255895==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 21 Nov 2022, at 13:57, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> Hello *,
>=20
> while trying to update libloc in IPFire 2.x, I noticed a possible quirk in =
the way the
> Perl module and man page files are currently installed. The rootfile diff l=
ooks as follows:
>=20
> diff --git a/config/rootfiles/common/libloc b/config/rootfiles/common/libloc
> index 7eb94217e..628ac343f 100644
> --- a/config/rootfiles/common/libloc
> +++ b/config/rootfiles/common/libloc
> @@ -1,3 +1,8 @@
> +#Location.3
> +Location.pm
> +#auto
> +#auto/Location
> +auto/Location/Location.so

This is very much incorrect and was probably introduced here:

  https://git.ipfire.org/?p=3Dlocation/libloc.git;a=3Dcommitdiff;h=3Db26c2109=
eaf229d8c297266f12cd4757d7f14eb8

What did the configure script print at the end for the perl directories? It l=
ooks like the paths are not correctly detected.

> #etc/cron.daily
> #etc/cron.daily/location-update
> usr/bin/location
> @@ -22,10 +27,6 @@ usr/bin/location
> #usr/lib/libloc.so
> usr/lib/libloc.so.1
> usr/lib/libloc.so.1.0.2
> -usr/lib/perl5/site_perl/5.36.0/xxxMACHINExxx-linux-thread-multi/Location.pm
> -#usr/lib/perl5/site_perl/5.36.0/xxxMACHINExxx-linux-thread-multi/auto/Loca=
tion
> -#usr/lib/perl5/site_perl/5.36.0/xxxMACHINExxx-linux-thread-multi/auto/Loca=
tion/.packlist
> -usr/lib/perl5/site_perl/5.36.0/xxxMACHINExxx-linux-thread-multi/auto/Locat=
ion/Location.so
> #usr/lib/pkgconfig/libloc.pc
> #usr/lib/python3.10/site-packages/_location.la
> usr/lib/python3.10/site-packages/_location.so
> @@ -38,7 +39,6 @@ usr/lib/python3.10/site-packages/location/i18n.py
> #usr/lib/python3.10/site-packages/location/importer.py
> usr/lib/python3.10/site-packages/location/logger.py
> #usr/share/locale/de/LC_MESSAGES/libloc.mo
> -#usr/share/man/man3/Location.3
> #var/lib/location
> var/lib/location/database.db
> var/lib/location/ipset
>=20
> It appears that, despite ./configure called with parameters such as "--disa=
ble-man-pages",
> libloc always installs a man page, and now places Perl files in the current=
 working directory
> rather than something like /usr/lib/perl5/site_perl/5.36.0/...
>=20
> Does the ./configure call need additional parameters? Is this behaviour int=
ended?

=E2=80=94-disable-man-pages is working okay as our own man pages are not inst=
alled.

The man page that is being installed is from the Perl module.

Potentially, we will need to pass this to the perl build scripts. I wouldn=E2=
=80=99t consider this a very high priority, so please open a bug and assign i=
t to Stefan.

-Michael

>=20
> Thanks, and best regards,
> Peter M=C3=BCller


--===============8592575333329255895==--