Re: [PATCH 1/9] pakfire: Refactor dblist seperating UI and logic

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

Hello,

> On 23 Mar 2022, at 19:18, Robin Roevens <robin.roevens(a)disroot.org> wrote:
> 
> Hi Michael
> 
> Robin Roevens schreef op di 22-03-2022 om 13:39 [+0100]:
>>>> diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi
>>>> index 65c67fb90..30a23128b 100644
>>>> --- a/html/cgi-bin/pakfire.cgi
>>>> +++ b/html/cgi-bin/pakfire.cgi
>>>> @@ -370,7 +370,17 @@ print <<END;
>>>>                                         <select name="UPDPAKS"
>>>> class="pflist" size="5" disabled>
>>>> END
>>>> 
>>>> -       &Pakfire::dblist("upgrade", "forweb");
>>>> +       my %coredb = &Pakfire::coredbinfo();
>>>> +       if (defined $coredb{'AvailableRelease'}) {
>>>> +               print "<option value=\"core\">Core-Update --
>>>> $coredb{'CoreVersion'} -- Release: $coredb{'Release'} ->
>>>> $coredb{'AvailableRelease'}</option>\n";
>>>> +       }
>>> 
>>> The strings “Core-Update” (without the dash) and “Release” should
>>> be
>>> translated so that they make sense in other languages. You can do
>>> that with $Lang::tr (I am sure you know).
>> Agreed, I don't think it was originally in this place as this came
>> out
>> of the previous dblist function. But you are right, I will use
>> Lang::tr
>> 
> 
> I looked in the translation files, and currently there doesn't seem to
> be a translation string for "Core Update" and "Release". Should I just
> add it (to English and Dutch, I can)? Or did I overlook it ?

Yes, please just add the strings that you will need.

There are plenty of people who are native Germans here. Please get one of them to contribute the German strings. I don’t know who else we have on this list, but of course other languages are welcome too :)

> 
> Regards
> 
> Robin
> 
> -- 
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>