From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/9] pakfire: Refactor dblist seperating UI and logic
Date: Wed, 23 Mar 2022 20:49:32 +0000
Message-ID: <D1C65FD3-B24D-42B7-BF6D-3CA013AE8B6F@ipfire.org>
In-Reply-To: <a96eb14da6466f29199cd3fa1d6775328e8acdb7.camel@sicho.home>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7074839022187286871=="
List-Id: <development.lists.ipfire.org>

--===============7074839022187286871==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 23 Mar 2022, at 19:18, Robin Roevens <robin.roevens(a)disroot.org> wrote:
>=20
> Hi Michael
>=20
> Robin Roevens schreef op di 22-03-2022 om 13:39 [+0100]:
>>>> diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi
>>>> index 65c67fb90..30a23128b 100644
>>>> --- a/html/cgi-bin/pakfire.cgi
>>>> +++ b/html/cgi-bin/pakfire.cgi
>>>> @@ -370,7 +370,17 @@ print <<END;
>>>>                                         <select name=3D"UPDPAKS"
>>>> class=3D"pflist" size=3D"5" disabled>
>>>> END
>>>>=20
>>>> -       &Pakfire::dblist("upgrade", "forweb");
>>>> +       my %coredb =3D &Pakfire::coredbinfo();
>>>> +       if (defined $coredb{'AvailableRelease'}) {
>>>> +               print "<option value=3D\"core\">Core-Update --
>>>> $coredb{'CoreVersion'} -- Release: $coredb{'Release'} ->
>>>> $coredb{'AvailableRelease'}</option>\n";
>>>> +       }
>>>=20
>>> The strings =E2=80=9CCore-Update=E2=80=9D (without the dash) and =E2=80=
=9CRelease=E2=80=9D should
>>> be
>>> translated so that they make sense in other languages. You can do
>>> that with $Lang::tr (I am sure you know).
>> Agreed, I don't think it was originally in this place as this came
>> out
>> of the previous dblist function. But you are right, I will use
>> Lang::tr
>>=20
>=20
> I looked in the translation files, and currently there doesn't seem to
> be a translation string for "Core Update" and "Release". Should I just
> add it (to English and Dutch, I can)? Or did I overlook it ?

Yes, please just add the strings that you will need.

There are plenty of people who are native Germans here. Please get one of the=
m to contribute the German strings. I don=E2=80=99t know who else we have on =
this list, but of course other languages are welcome too :)

>=20
> Regards
>=20
> Robin
>=20
> --=20
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>=20


--===============7074839022187286871==--