From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] BUG12403: Fix permissions of DMA configfile Date: Mon, 11 May 2020 09:35:46 +0100 Message-ID: In-Reply-To: <20200509060642.4551-1-alexander.marx@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7635855064823248404==" List-Id: --===============7635855064823248404== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, > On 9 May 2020, at 07:06, Alexander Marx wrote: >=20 > From: Alexander Marx Your Git is set up with a different email address for commits than what you a= re using for email. Is this intentional? > Change read permissions of dma configfile so other users are able to read i= t. > Needed for Addons like WIO to send Mails. I am not sure if this patch is a good idea. We will make the credentials read= able for everyone. What would probably work better is a group called =E2=80=9Cmail=E2=80=9D whic= h nobody and wio will be a member of so that they can read the configuration = file. Others still won=E2=80=99t be able to read it. What do you think about this solution? Best, -Michael >=20 > FIXES: #12403 > --- > lfs/dma | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/lfs/dma b/lfs/dma > index aceb2704e..6b5d9bfbf 100644 > --- a/lfs/dma > +++ b/lfs/dma > @@ -24,7 +24,7 @@ >=20 > include Config >=20 > -VER =3D 0.12 > +VER =3D 0.13 >=20 > THISAPP =3D dma-$(VER) > DL_FILE =3D $(THISAPP).tar.gz > @@ -80,6 +80,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > install -v -m 755 $(DIR_SRC)/config/dma/dma-cleanup-spool /usr/sbin > chown -R nobody.nobody /var/ipfire/dma > chown nobody.root /var/ipfire/dma/auth.conf > + chmod 644 /var/ipfire/dma/auth.conf > ln -svf dma /usr/sbin/sendmail.dma > /usr/sbin/alternatives --install /usr/sbin/sendmail sendmail /usr/sbin/sen= dmail.dma 20 > @rm -rf $(DIR_APP) > --=20 > 2.17.1 >=20 --===============7635855064823248404==--