From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2 7/8] wireless-regdb: Use db.txt file for wlanap.cgi
Date: Wed, 04 Aug 2021 16:34:19 +0200
Message-ID: <D8534138-73A9-4535-B11B-0DB64652E0AD@ipfire.org>
In-Reply-To: <20210728172932.2737967-7-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8541126173291228701=="
List-Id: <development.lists.ipfire.org>

--===============8541126173291228701==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

This whole patch set looks very good.

I am just wondering if =E2=80=9Cdb.txt=E2=80=9D isn=E2=80=99t a bit generic f=
or the file?

Should we not call it /lib/firmware/regulatory.txt?

-Michael

> On 28 Jul 2021, at 19:29, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> - db.txt is the text file version of the wireless settings by country datab=
ase
> - Using db.txt means that regdbdump from crda is not required by wlanap.cgi
> - This patch copies the db.txt file from the source tarball to /lib/firmwar=
e/ where
>   it can be read by wlanap.cgi
> - Updated rootfile to include db.txt
>=20
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/rootfiles/common/wireless-regdb | 1 +
> lfs/wireless-regdb                     | 1 +
> 2 files changed, 2 insertions(+)
>=20
> diff --git a/config/rootfiles/common/wireless-regdb b/config/rootfiles/comm=
on/wireless-regdb
> index 7e830ae1f..2ebbfc169 100644
> --- a/config/rootfiles/common/wireless-regdb
> +++ b/config/rootfiles/common/wireless-regdb
> @@ -1,3 +1,4 @@
> +lib/firmware/db.txt
> lib/firmware/regulatory.db
> lib/firmware/regulatory.db.p7s
> #usr/lib/crda
> diff --git a/lfs/wireless-regdb b/lfs/wireless-regdb
> index 6cffd34ba..1ef7da231 100644
> --- a/lfs/wireless-regdb
> +++ b/lfs/wireless-regdb
> @@ -72,5 +72,6 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> 	@$(PREBUILD)
> 	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> 	cd $(DIR_APP) && make install
> +	cp -vf $(DIR_APP)/db.txt /lib/firmware/db.txt
> 	@rm -rf $(DIR_APP)
> 	@$(POSTBUILD)
> --=20
> 2.32.0
>=20


--===============8541126173291228701==--