Re: Question regarding orphaned files on existing IPFire installations

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2747 bytes --]

Hello,

> On 19 Mar 2022, at 17:05, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Hello development folks,
> 
> while preparing some of the last Core Updates, I frequently came across rootfile
> changes, or patches making some files previously shipped (and therefore present on
> existing IPFire installations) obsolete.
> 
> By accident, I stumbled across some of these files again, and would therefore like
> to raise the question of what to do with them. Should I, being in responsible for
> a certain Core Update, delete these via the update.sh script?

Yes, this is how it should be done.

> (This would mean to check every rootfile change for deleted files, and include them
> in an 'rm' block in the update.sh script. I am willing to put that effort in, but
> want to make sure this is desired.)

Yes it is.

We have never done a very good job with this, because the diff of the filelists between updates can be rather long and we have no automatic way how to determine this.

However, since we have the filesystem cleanup script that already tidies up any libraries, this should become a lot easier because there isn’t as much fluctuation in /bin, /usr/bin and so on. If anything, there are normally new files.

> Also, I recently came across some scripts such as ovpn-ccd-convert no longer needed.

I merged this patch. Thank you.

> For whatever reason, /usr/share/GeoIP/ is also still present on all IPFire machines
> I administer, although it should have been deleted during the update to Core 140.

Please send a patch to delete it for c166 then.

> If I come across such incidents, should I include them in the 'rm' block of an
> update.sh script as well?

Yes. Files should be deleted before any new ones are extracted (just in case), and so we should also rather have more space available than too little.

> Threads regarding full filesystems come up at https://community.ipfire.org/ on
> a regular, but not worryingly frequency. I am getting the feeling that we are not
> always cleaning up leftovers during updates as thorough as we could to. :-)

I do not believe that there is substantial space to be freed on the root partition.

People with older installations have a / partition that is only 2GB and I hope that compressing the firmware will free up enough space that those systems will be able to function without requirement to be reinstalled with a new partition layout.

> Thanks, and best regards,
> Peter Müller
> 
> P.S.: Also, I am back in action, and can take care of Core Update 167 (or 166, if
> there is something left to do on it), if desired. Just drop me a line.

Yes, please take over the Core Updates again. That saves me a lot of time :)