From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Question regarding orphaned files on existing IPFire installations Date: Mon, 21 Mar 2022 11:40:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5905152243086133800==" List-Id: --===============5905152243086133800== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, > On 19 Mar 2022, at 17:05, Peter M=C3=BCller wr= ote: >=20 > Hello development folks, >=20 > while preparing some of the last Core Updates, I frequently came across roo= tfile > changes, or patches making some files previously shipped (and therefore pre= sent on > existing IPFire installations) obsolete. >=20 > By accident, I stumbled across some of these files again, and would therefo= re like > to raise the question of what to do with them. Should I, being in responsib= le for > a certain Core Update, delete these via the update.sh script? Yes, this is how it should be done. > (This would mean to check every rootfile change for deleted files, and incl= ude them > in an 'rm' block in the update.sh script. I am willing to put that effort i= n, but > want to make sure this is desired.) Yes it is. We have never done a very good job with this, because the diff of the filelis= ts between updates can be rather long and we have no automatic way how to det= ermine this. However, since we have the filesystem cleanup script that already tidies up a= ny libraries, this should become a lot easier because there isn=E2=80=99t as = much fluctuation in /bin, /usr/bin and so on. If anything, there are normally= new files. > Also, I recently came across some scripts such as ovpn-ccd-convert no longe= r needed. I merged this patch. Thank you. > For whatever reason, /usr/share/GeoIP/ is also still present on all IPFire = machines > I administer, although it should have been deleted during the update to Cor= e 140. Please send a patch to delete it for c166 then. > If I come across such incidents, should I include them in the 'rm' block of= an > update.sh script as well? Yes. Files should be deleted before any new ones are extracted (just in case)= , and so we should also rather have more space available than too little. > Threads regarding full filesystems come up at https://community.ipfire.org/= on > a regular, but not worryingly frequency. I am getting the feeling that we a= re not > always cleaning up leftovers during updates as thorough as we could to. :-) I do not believe that there is substantial space to be freed on the root part= ition. People with older installations have a / partition that is only 2GB and I hop= e that compressing the firmware will free up enough space that those systems = will be able to function without requirement to be reinstalled with a new par= tition layout. > Thanks, and best regards, > Peter M=C3=BCller >=20 > P.S.: Also, I am back in action, and can take care of Core Update 167 (or 1= 66, if > there is something left to do on it), if desired. Just drop me a line. Yes, please take over the Core Updates again. That saves me a lot of time :) --===============5905152243086133800==--