public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: sendEmail-1.56-1
Date: Fri, 08 Feb 2019 12:29:02 +0000	[thread overview]
Message-ID: <D8912B44-1081-41E7-A77C-68C313DB5362@ipfire.org> (raw)
In-Reply-To: <q3fjv3$tob$1@tuscan3.grantura.co.uk>

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

Hi,

> On 6 Feb 2019, at 21:35, Rob Brewer <ipfire-devel(a)grantura.co.uk> wrote:
> 
> Hi Michael
> 
> Michael Tremer wrote:
> 
>> Hi,
>> 
>> Thanks for sending the patch.
>> 
>> I agree that 503.tape is incorrect, but would say that sendEmail should be
>> owned by root.root and have 755 as permissions.
>> 
>> Why does the script need to become root when it is being executed by
>> nobody? I think that is a security risk.
>> 
> Because those were the owners and permissions with sendEmail in IPCop and I 
> have an IPCop addon that uses sendEmail to send my firewall logs to Dshield. 
> I dont think a group ID of nobody is essential for this addon though.

No. Please change the patch accordingly and submit again.

Regarding the IPCop add-on: Please do not use sendEmail. It does not do the job.

We have dma, a small mail agent that can be configured over the web-ui. It does proper bounce handling and will try to send the email again in case the first attempt failed. sendEmail doesn’t do that.

> The addon based on the IPCop logsend addon been running for the last few 
> months on my IPFire but need a little more work before I can release it 
> here.
> 
> (watch this space :) )
> 
> Rob

-Michael

  reply	other threads:[~2019-02-08 12:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02 18:47 sendEmail-1.56-1 Bob Brewer
2019-02-06 11:13 ` sendEmail-1.56-1 Michael Tremer
2019-02-06 21:35   ` sendEmail-1.56-1 Rob Brewer
2019-02-08 12:29     ` Michael Tremer [this message]
2019-02-10 17:49       ` sendEmail-1.56-1 Rob Brewer
2019-02-10 22:00         ` sendEmail-1.56-1 Rob Brewer
2019-02-13 17:25           ` sendEmail-1.56-1 Michael Tremer
2019-02-13 22:49             ` [PATCH] sendEmail Rob Brewer
2019-02-14 11:06               ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D8912B44-1081-41E7-A77C-68C313DB5362@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox