From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] backup.cgi: Cosmetic fix - mark backup files bold for
 better readability
Date: Fri, 22 May 2020 13:39:19 +0100
Message-ID: <D915EE99-6250-436A-A3C7-13336202CDDD@ipfire.org>
In-Reply-To: <20200522121338.4908-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3527794924865095595=="
List-Id: <development.lists.ipfire.org>

--===============3527794924865095595==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hey,

Can you post a screenshot about what has changed and why this was a problem f=
or you?

Best,
-Michael

> On 22 May 2020, at 13:13, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/backup.cgi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/html/cgi-bin/backup.cgi b/html/cgi-bin/backup.cgi
> index cac4146ab..3ced1371d 100644
> --- a/html/cgi-bin/backup.cgi
> +++ b/html/cgi-bin/backup.cgi
> @@ -202,7 +202,7 @@ my $Datei =3D "/var/ipfire/backup/".$_;
> my @Info =3D stat($Datei);
> my $Size =3D $Info[7] / 1024 / 1024;
> $Size =3D sprintf("%0.2f", $Size);
> -print "<tr><td align=3D'center'>$Lang::tr{'backup from'} $_ $Lang::tr{'siz=
e'} $Size MB</td><td width=3D'5'><form method=3D'post' action=3D'$ENV{'SCRIPT=
_NAME'}'><input type=3D'hidden' name=3D'ACTION' value=3D'download' /><input t=
ype=3D'hidden' name=3D'FILE' value=3D'$_' /><input type=3D'image' alt=3D'$Lan=
g::tr{'download'}' title=3D'$Lang::tr{'download'}' src=3D'/images/package-x-g=
eneric.png' /></form></td>";
> +print "<tr><td align=3D'center'>$Lang::tr{'backup from'} <b>$_</b> $Lang::=
tr{'size'} $Size MB</td><td width=3D'5'><form method=3D'post' action=3D'$ENV{=
'SCRIPT_NAME'}'><input type=3D'hidden' name=3D'ACTION' value=3D'download' /><=
input type=3D'hidden' name=3D'FILE' value=3D'$_' /><input type=3D'image' alt=
=3D'$Lang::tr{'download'}' title=3D'$Lang::tr{'download'}' src=3D'/images/pac=
kage-x-generic.png' /></form></td>";
> print "<td width=3D'5'><form method=3D'post' action=3D'$ENV{'SCRIPT_NAME'}'=
><input type=3D'hidden' name=3D'ACTION' value=3D'delete' /><input type=3D'hid=
den' name=3D'FILE' value=3D'$_' /><input type=3D'image' alt=3D'$Lang::tr{'del=
ete'}' title=3D'$Lang::tr{'delete'}' src=3D'/images/user-trash.png' /></form>=
</td></tr>";
> }
> foreach (@backupisos){
> @@ -212,7 +212,7 @@ my $Datei =3D "/var/tmp/backupiso/".$_;
> my @Info =3D stat($Datei);
> my $Size =3D $Info[7] / 1024 / 1024;
> $Size =3D sprintf("%0.2f", $Size);
> -print "<tr><td align=3D'center'>$Lang::tr{'backup from'} $_ $Lang::tr{'siz=
e'} $Size MB</td><td width=3D'5'><form method=3D'post' action=3D'$ENV{'SCRIPT=
_NAME'}'><input type=3D'hidden' name=3D'ACTION' value=3D'downloadiso' /><inpu=
t type=3D'hidden' name=3D'FILE' value=3D'$_' /><input type=3D'image' alt=3D'$=
Lang::tr{'download'}' title=3D'$Lang::tr{'download'}' src=3D'/images/package-=
x-generic.png' /></form></td>";
> +print "<tr><td align=3D'center'>$Lang::tr{'backup from'} <b>$_</b> $Lang::=
tr{'size'} $Size MB</td><td width=3D'5'><form method=3D'post' action=3D'$ENV{=
'SCRIPT_NAME'}'><input type=3D'hidden' name=3D'ACTION' value=3D'downloadiso' =
/><input type=3D'hidden' name=3D'FILE' value=3D'$_' /><input type=3D'image' a=
lt=3D'$Lang::tr{'download'}' title=3D'$Lang::tr{'download'}' src=3D'/images/p=
ackage-x-generic.png' /></form></td>";
> print "<td width=3D'5'><form method=3D'post' action=3D'$ENV{'SCRIPT_NAME'}'=
><input type=3D'hidden' name=3D'ACTION' value=3D'delete' /><input type=3D'hid=
den' name=3D'FILE' value=3D'$_' /><input type=3D'image' alt=3D'$Lang::tr{'del=
ete'}' title=3D'$Lang::tr{'delete'}' src=3D'/images/user-trash.png' /></form>=
</td></tr>";
> }
> print <<END
> @@ -246,10 +246,10 @@ my $Size =3D $Info[7] / 1024;
> if ( -e $Datei ){
> 	if ($Size < 1) {
> 			$Size =3D sprintf("%.2f", $Size);
> -			print "<tr><td align=3D'center'>$Lang::tr{'backup from'} $_ $Lang::tr{'=
size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
> +			print "<tr><td align=3D'center'>$Lang::tr{'backup from'} <b>$_</b> $Lan=
g::tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
> 	} else {
> 			$Size =3D sprintf("%2d", $Size);
> -			print "<tr><td align=3D'center'>$Lang::tr{'backup from'} $_ $Lang::tr{'=
size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
> +			print "<tr><td align=3D'center'>$Lang::tr{'backup from'} <b>$_</b> $Lan=
g::tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
>=20
> 	}
>=20
> @@ -272,7 +272,7 @@ END
> ;
> }
> else{
> -  print "<tr><td align=3D'center'>$Lang::tr{'backup from'} $_ </td><td wid=
th=3D'5' align=3D'right'></td><td width=3D'5' align=3D'right'></td>";
> +  print "<tr><td align=3D'center'>$Lang::tr{'backup from'} <b>$_</b> </td>=
<td width=3D'5' align=3D'right'></td><td width=3D'5' align=3D'right'></td>";
> }
> print <<END
> 	<td align=3D'right' width=3D'5'>
> @@ -291,7 +291,7 @@ my $Datei =3D "/var/ipfire/backup/addons/backup/".$_.".=
ipf";
> my @Info =3D stat($Datei);
> my $Size =3D $Info[7] / 1024;
> $Size =3D sprintf("%2d", $Size);
> -print "<tr><td align=3D'center'>$Lang::tr{'backup from'} $_ $Lang::tr{'siz=
e'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
> +print "<tr><td align=3D'center'>$Lang::tr{'backup from'} <b>$_</b> $Lang::=
tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
> print <<END
> 	<td align=3D'right' width=3D'5'>
> 		<form method=3D'post' action=3D'$ENV{'SCRIPT_NAME'}'>
> --=20
> 2.18.0
>=20


--===============3527794924865095595==--