Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

Are there any other providers that are still using HTTP? If so we should either upgrade them to HTTPS or remove them because they got stuck in the early 2000s.

-Michael

> On 7 Feb 2020, at 11:32, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> lfs/ddns                                  |  3 +++
> src/patches/ddns-013-dyfi-use-https.patch | 22 ++++++++++++++++++++++
> 2 files changed, 25 insertions(+)
> create mode 100644 src/patches/ddns-013-dyfi-use-https.patch
> 
> diff --git a/lfs/ddns b/lfs/ddns
> index 89ab02e96..0e045ddc4 100644
> --- a/lfs/ddns
> +++ b/lfs/ddns
> @@ -71,6 +71,9 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> 	@$(PREBUILD)
> 	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> 
> +	# Apply upstream patches.
> +	cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-013-dyfi-use-https.patch
> +
> 	cd $(DIR_APP) && [ -x "configure" ] || sh ./autogen.sh
> 	cd $(DIR_APP) && ./configure \
> 		--prefix=/usr \
> diff --git a/src/patches/ddns-013-dyfi-use-https.patch b/src/patches/ddns-013-dyfi-use-https.patch
> new file mode 100644
> index 000000000..f131c5b24
> --- /dev/null
> +++ b/src/patches/ddns-013-dyfi-use-https.patch
> @@ -0,0 +1,22 @@
> +commit ce6e977f0ace7fe468411270ad07f1824a3aeaec
> +Author: Mauno Pirnes <mauno.pirnes(a)hotmail.com>
> +Date:   Fri Feb 7 12:25:00 2020 +0100
> +
> +    dy.fi: Use HTTPS to perform updates.
> +    
> +    Signed-off-by: Mauno Pirnes <mauno.pirnes(a)hotmail.com>
> +    Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +
> +diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> +index dcdc5da..f1fed22 100644
> +--- a/src/ddns/providers.py
> ++++ b/src/ddns/providers.py
> +@@ -826,7 +826,7 @@ class DDNSProviderDyFi(DDNSProtocolDynDNS2, DDNSProvider):
> + 	# https://www.dy.fi/page/clients?lang=en
> + 	# https://www.dy.fi/page/specification?lang=en
> + 
> +-	url = "http://www.dy.fi/nic/update"
> ++	url = "https://www.dy.fi/nic/update"
> + 
> + 	# Please only send automatic updates when your IP address changes,
> + 	# or once per 5 to 6 days to refresh the address mapping (they will
> -- 
> 2.25.0
>