From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 3/3] llvm: New package
Date: Thu, 04 Jul 2019 16:01:24 +0100
Message-ID: <DB094876-52B7-4FD4-A72C-6E99D4A24651@ipfire.org>
In-Reply-To: <20190704122312.9655-3-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3203721747376259988=="
List-Id: <development.lists.ipfire.org>

--===============3203721747376259988==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 4 Jul 2019, at 13:23, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> llvm/llvm.nm | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 113 insertions(+)
> create mode 100644 llvm/llvm.nm
>=20
> diff --git a/llvm/llvm.nm b/llvm/llvm.nm
> new file mode 100644
> index 000000000..7e89256d3
> --- /dev/null
> +++ b/llvm/llvm.nm
> @@ -0,0 +1,113 @@
> +##########################################################################=
#####
> +# IPFire.org    - An Open Source Firewall Solution                        =
    #
> +# Copyright (C) - IPFire Development Team <info(a)ipfire.org>             =
      #
> +##########################################################################=
#####
> +
> +name       =3D llvm
> +version    =3D 8.0.0
> +release    =3D 1
> +
> +groups     =3D Applications/System
> +url        =3D http://llvm.org
> +license    =3D NCSA
> +summary    =3D The Low Level Virtual Machine.
> +
> +description
> +	LLVM is a compiler infrastructure designed for compile-time, link-time,
> +	runtime, and idle-time optimization of programs from arbitrary programming
> +	languages. The compiler infrastructure includes mirror sets of programming
> +	tools as well as libraries with equivalent functionality.
> +end
> +
> +source_dl  =3D http://releases.llvm.org/%{version}/
> +sources    =3D %{thisapp}.src.tar.xz
> +
> +build
> +	requires
> +		binutils >=3D 2.32
> +		cmake >=3D 3.14.5
> +		gcc
> +		gcc-c++
> +		libedit-devel 3.1-20190324

You forgot the >=3D sign here which I had to add in order to build this.

> +		libffi-devel
> +		libxml2-devel
> +		zlib-devel
> +	end
> +
> +	DIR_APP =3D %{DIR_SRC}/%{thisapp}.src
> +
> +	# Limit parallelization to only 2 jobs at the same time.
> +	PARALLELISMFLAGS =3D -j2
> +
> +	# Set suffix for libdir based on the build architecture.
> +	llvm_libdir_suffix =3D
> +
> +	if "%{DISTRO_ARCH}" =3D=3D "x86_64"
> +		llvm_libdir_suffix =3D 64
> +	end
> +
> +	if "%{DISTRO_ARCH}" =3D=3D "aarch64"
> +		llvm_libdir_suffix =3D 64
> +	end
> +
> +	build
> +		# Create and switch into build directory.
> +		mkdir -pv %{DIR_APP}/build
> +		cd %{DIR_APP}/build
> +
> +		%{cmake} .. \
> +			-DLLVM_BUILD_TOOLS=3DON \
> +			-DLLVM_BUILD_UTILS=3DON \
> +			-DLLVM_BUILD_TESTS=3DOFF \
> +			-DLLVM_BUILD_EXAMPLES=3DOFF \
> +			-DLLVM_BUILD_BENCHMARKS=3DOFF \
> +			-DCMAKE_BUILD_TYPE=3DRelease \

Do we not want debug info here?

> +			-DCMAKE_INSTALL_RPATH=3D";" \
> +			-DLLVM_BUILD_LLVM_DYLIB=3DOFF \
> +			-DLLVM_LINK_LLVM_DYLIB=3DOFF \
> +			-DBUILD_SHARED_LIBS=3DON \
> +			-DLLVM_ENABLE_FFI=3DON \
> +			-DLLVM_ENABLE_RTTI=3DON \
> +			-DLLVM_ENABLE_LIBCXX=3DOFF \
> +			-DLLVM_TARGETS_TO_BUILD=3D"host;" \
> +			-DCMAKE_C_COMPILER=3Dgcc \
> +			-DCMAKE_CXX_COMPILER=3Dg++ \
> +			-DCMAKE_CXX_FLAGS_RELEASE:STRING=3D"%{CFLAGS}" \
> +			-DCMAKE_EXE_LINKER_FLAGS=3D"%{LDFLAGS}" \
> +			-DENABLE_PIC=3D1 \
> +			-DLLVM_PARALLEL_LINK_JOBS=3D1 \

What is this for? Why can we not do this in parallel?

> +			-DLLVM_ENABLE_DUMP=3DON \
> +			-DLLVM_LIBDIR_SUFFIX=3D%{llvm_libdir_suffix} \
> +			-Wno-dev
> +
> +		make %{PARALELLISMFLAGS}
> +	end
> +
> +	test
> +		cd %{DIR_APP}/build
> +
> +		make check-all %{PARALELLISMFLAGS}
> +	end
> +
> +	install
> +		cd %{DIR_APP}/build
> +
> +		make install DESTDIR=3D%{BUILDROOT}
> +	end
> +end
> +
> +packages
> +	package llvm
> +
> +	package llvm-libs
> +		template LIBS
> +	end
> +
> +	package llvm-devel
> +		template DEVEL
> +	end
> +
> +	package %{name}-debuginfo
> +		template DEBUGINFO
> +	end
> +end
> --=20
> 2.21.0
>=20


--===============3203721747376259988==--