Re: [PATCH] squid: Update to 5.2

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2579 bytes --]

Hello,

> On 9 Oct 2021, at 14:00, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Hi,
> 
> On 09.10.2021 14:47, Michael Tremer wrote:
>> Hello,
>> 
>> I would say that 16k should be fine. 32k would be even better.
>> 
>> It probably only becomes a problem on a very busy proxy with a lot of open (but idle) connections.
> 
> This leaves me in the state "Remove or not?" ;-)
> 
> My two cents: Let the user decide and leave this setting as it is...

My metric always is: If we don’t know, how does the user?

The only thing we don’t know is how many connections the user is expecting. But we know the technical details.

Let’s do it 32k and if that isn’t enough someone will open a bug report.

-Michael

> Opinions?
> 
> Matthias
> 
>> -Michael
>> 
>>> On 9 Oct 2021, at 13:46, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>> 
>>> Hi,
>>> 
>>> On 09.10.2021 14:06, Michael Tremer wrote:
>>>> Hey,
>>>> 
>>>> Are we ready to got to squid 5, yet?
>>> 
>>> Up and running here, but...
>>> 
>>>> I thought there were some remaining changes required in the CGI file?
>>> 
>>> ...the question is whether we adopt the new maximum of 32k
>>> filedescriptors as a fixed setting and remove the corresponding
>>> adjustment field or leave the user the possibility to influence these
>>> settings via GUI.
>>> 
>>> I'm testing here with '16384' and didn't see any problem with that. If
>>> it is desired I can of course remove the setting, I just didn't see the
>>> need so far.
>>> 
>>>> -Michael
>>>> 
>>>>> On 8 Oct 2021, at 18:19, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>>>> 
>>>>> For details see:
>>>>> http://www.squid-cache.org/Versions/v5/changesets/
>>>>> 
>>>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>>>> ---
>>>>> lfs/squid | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>> 
>>>>> diff --git a/lfs/squid b/lfs/squid
>>>>> index c56dca7de..5e9648aba 100644
>>>>> --- a/lfs/squid
>>>>> +++ b/lfs/squid
>>>>> @@ -24,7 +24,7 @@
>>>>> 
>>>>> include Config
>>>>> 
>>>>> -VER        = 5.1
>>>>> +VER        = 5.2
>>>>> 
>>>>> THISAPP    = squid-$(VER)
>>>>> DL_FILE    = $(THISAPP).tar.xz
>>>>> @@ -46,7 +46,7 @@ objects = $(DL_FILE)
>>>>> 
>>>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>>>> 
>>>>> -$(DL_FILE)_MD5 = 17be9709b54fe0146452113404be7b54
>>>>> +$(DL_FILE)_MD5 = 102984f3ea382a1fa5bd917c2ee155ec
>>>>> 
>>>>> install : $(TARGET)
>>>>> 
>>>>> -- 
>>>>> 2.18.0
>>>>> 
>>>> 
>>> 
>> 
>