From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] squid: Update to 5.2
Date: Thu, 14 Oct 2021 20:24:34 +0100
Message-ID: <DC640B6E-E3AC-4EE9-8BFE-060BA4BF6FDB@ipfire.org>
In-Reply-To: <d51478cf-90da-fc1b-5daa-d01d0e91f1e9@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7661464124257156452=="
List-Id: <development.lists.ipfire.org>

--===============7661464124257156452==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 9 Oct 2021, at 14:00, Matthias Fischer <matthias.fischer(a)ipfire.org> w=
rote:
>=20
> Hi,
>=20
> On 09.10.2021 14:47, Michael Tremer wrote:
>> Hello,
>>=20
>> I would say that 16k should be fine. 32k would be even better.
>>=20
>> It probably only becomes a problem on a very busy proxy with a lot of open=
 (but idle) connections.
>=20
> This leaves me in the state "Remove or not?" ;-)
>=20
> My two cents: Let the user decide and leave this setting as it is...

My metric always is: If we don=E2=80=99t know, how does the user?

The only thing we don=E2=80=99t know is how many connections the user is expe=
cting. But we know the technical details.

Let=E2=80=99s do it 32k and if that isn=E2=80=99t enough someone will open a =
bug report.

-Michael

> Opinions?
>=20
> Matthias
>=20
>> -Michael
>>=20
>>> On 9 Oct 2021, at 13:46, Matthias Fischer <matthias.fischer(a)ipfire.org>=
 wrote:
>>>=20
>>> Hi,
>>>=20
>>> On 09.10.2021 14:06, Michael Tremer wrote:
>>>> Hey,
>>>>=20
>>>> Are we ready to got to squid 5, yet?
>>>=20
>>> Up and running here, but...
>>>=20
>>>> I thought there were some remaining changes required in the CGI file?
>>>=20
>>> ...the question is whether we adopt the new maximum of 32k
>>> filedescriptors as a fixed setting and remove the corresponding
>>> adjustment field or leave the user the possibility to influence these
>>> settings via GUI.
>>>=20
>>> I'm testing here with '16384' and didn't see any problem with that. If
>>> it is desired I can of course remove the setting, I just didn't see the
>>> need so far.
>>>=20
>>>> -Michael
>>>>=20
>>>>> On 8 Oct 2021, at 18:19, Matthias Fischer <matthias.fischer(a)ipfire.or=
g> wrote:
>>>>>=20
>>>>> For details see:
>>>>> http://www.squid-cache.org/Versions/v5/changesets/
>>>>>=20
>>>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>>>> ---
>>>>> lfs/squid | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>=20
>>>>> diff --git a/lfs/squid b/lfs/squid
>>>>> index c56dca7de..5e9648aba 100644
>>>>> --- a/lfs/squid
>>>>> +++ b/lfs/squid
>>>>> @@ -24,7 +24,7 @@
>>>>>=20
>>>>> include Config
>>>>>=20
>>>>> -VER        =3D 5.1
>>>>> +VER        =3D 5.2
>>>>>=20
>>>>> THISAPP    =3D squid-$(VER)
>>>>> DL_FILE    =3D $(THISAPP).tar.xz
>>>>> @@ -46,7 +46,7 @@ objects =3D $(DL_FILE)
>>>>>=20
>>>>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>>>>=20
>>>>> -$(DL_FILE)_MD5 =3D 17be9709b54fe0146452113404be7b54
>>>>> +$(DL_FILE)_MD5 =3D 102984f3ea382a1fa5bd917c2ee155ec
>>>>>=20
>>>>> install : $(TARGET)
>>>>>=20
>>>>> --=20
>>>>> 2.18.0
>>>>>=20
>>>>=20
>>>=20
>>=20
>=20


--===============7661464124257156452==--