From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: diagrams - all over the CGIs
Date: Mon, 25 May 2020 10:27:21 +0100
Message-ID: <DDD06636-4846-4D2A-804E-55CAED713E45@ipfire.org>
In-Reply-To: <1b69843a-4d60-d646-5cd5-dc5f975fbaa7@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3832670279366405566=="
List-Id: <development.lists.ipfire.org>

--===============3832670279366405566==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi David,

Sorry to hear that your comment was lost somewhere.

But we like patches, so maybe send those :)

-Michael

> On 24 May 2020, at 21:50, David Allen <codermotor(a)gmail.com> wrote:
>=20
> Yay!
> As a lowly user, I mentioned this a few years ago but I figured my comment =
just went into the bit bucket. I'm glad I'm not the only one to see those "Du=
h!"s all over the place :-D
>=20
>=20
> On 5/13/20 2:59 AM, Michael Tremer wrote:
>> Hi,
>>> On 13 May 2020, at 09:38, Matthias Fischer <matthias.fischer(a)ipfire.org=
> wrote:
>>>=20
>>> Hi,
>>>=20
>>> this just came to my view while looking at Peters patches for
>>> 'system.cgi' and 'graphs.pl' ("properly translate load average graph").
>>>=20
>>> Searching for the translation string  ...$Lang::tr{'graph'}... I found
>>> it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'.
>>>=20
>>> What are these repetitions good for?
>>>=20
>>> I mean, you click on "Network (external)". You read the topic
>>> "Net-Traffic graphs (external)" or "... (internal).
>>>=20
>>> You know: here I'll find ... graphs. Ok. Lets see.
>>>=20
>>> But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or
>>> CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda
>>> *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again?
>> Yeah, we absolutely do not need that word in the headline.
>> =E2=80=9CMemory=E2=80=9D should make it clear what we are showing. It is o=
bvious that the graph is a graph.
>>> My two cents: I think we don't need this translation string at these
>>> specific points in the WUI.
>> Would you like to send in a patch for this?
>> Best,
>> -Michael
>>>=20
>>> Opinions?
>>>=20
>>> Best,
>>> Matthias
>=20


--===============3832670279366405566==--