From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] Apache: deny framing of WebUI from different origins
Date: Tue, 05 Nov 2019 10:34:11 +0000 [thread overview]
Message-ID: <DE2C8DB5-388D-459C-A2BF-99D8D5C2BAED@ipfire.org> (raw)
In-Reply-To: <e0dd8324-866c-28c8-9e03-12866e132cce@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]
Acked-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 4 Nov 2019, at 18:53, peter.mueller(a)ipfire.org wrote:
>
> There is no legitimate reason to do this. Setting header X-Frame-Options
> to "sameorigin" is necessary for displaying some collectd graphs on the
> WebUI.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/httpd/vhosts.d/ipfire-interface-ssl.conf | 1 +
> config/httpd/vhosts.d/ipfire-interface.conf | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/config/httpd/vhosts.d/ipfire-interface-ssl.conf b/config/httpd/vhosts.d/ipfire-interface-ssl.conf
> index dc1151110..de7b8559d 100644
> --- a/config/httpd/vhosts.d/ipfire-interface-ssl.conf
> +++ b/config/httpd/vhosts.d/ipfire-interface-ssl.conf
> @@ -23,6 +23,7 @@
> Header always set X-Content-Type-Options nosniff
> Header always set Content-Security-Policy "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline'"
> Header always set Referrer-Policy strict-origin
> + Header always set X-Frame-Options sameorigin
>
> <Directory /srv/web/ipfire/html>
> Options ExecCGI
> diff --git a/config/httpd/vhosts.d/ipfire-interface.conf b/config/httpd/vhosts.d/ipfire-interface.conf
> index d95fa264f..2cf57dd29 100644
> --- a/config/httpd/vhosts.d/ipfire-interface.conf
> +++ b/config/httpd/vhosts.d/ipfire-interface.conf
> @@ -9,6 +9,7 @@
> Header always set X-Content-Type-Options nosniff
> Header always set Content-Security-Policy "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline'"
> Header always set Referrer-Policy strict-origin
> + Header always set X-Frame-Options sameorigin
>
> <Directory /srv/web/ipfire/html>
> Options ExecCGI
> --
> 2.16.4
next prev parent reply other threads:[~2019-11-05 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 18:52 [PATCH 1/2] Apache: prevent Referrer leaks via WebUI peter.mueller
2019-11-04 18:53 ` [PATCH 2/2] Apache: deny framing of WebUI from different origins peter.mueller
2019-11-05 10:34 ` Michael Tremer [this message]
2019-11-05 10:34 ` [PATCH 1/2] Apache: prevent Referrer leaks via WebUI Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE2C8DB5-388D-459C-A2BF-99D8D5C2BAED@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox