From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] Apache: deny framing of WebUI from different origins
Date: Tue, 05 Nov 2019 10:34:11 +0000
Message-ID: <DE2C8DB5-388D-459C-A2BF-99D8D5C2BAED@ipfire.org>
In-Reply-To: <e0dd8324-866c-28c8-9e03-12866e132cce@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8380398467929010487=="
List-Id: <development.lists.ipfire.org>

--===============8380398467929010487==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Acked-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 4 Nov 2019, at 18:53, peter.mueller(a)ipfire.org wrote:
>=20
> There is no legitimate reason to do this. Setting header X-Frame-Options
> to "sameorigin" is necessary for displaying some collectd graphs on the
> WebUI.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/httpd/vhosts.d/ipfire-interface-ssl.conf | 1 +
> config/httpd/vhosts.d/ipfire-interface.conf     | 1 +
> 2 files changed, 2 insertions(+)
>=20
> diff --git a/config/httpd/vhosts.d/ipfire-interface-ssl.conf b/config/httpd=
/vhosts.d/ipfire-interface-ssl.conf
> index dc1151110..de7b8559d 100644
> --- a/config/httpd/vhosts.d/ipfire-interface-ssl.conf
> +++ b/config/httpd/vhosts.d/ipfire-interface-ssl.conf
> @@ -23,6 +23,7 @@
>     Header always set X-Content-Type-Options nosniff
>     Header always set Content-Security-Policy "default-src 'self'; script-s=
rc 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline'"
>     Header always set Referrer-Policy strict-origin
> +    Header always set X-Frame-Options sameorigin
>=20
>     <Directory /srv/web/ipfire/html>
>         Options ExecCGI
> diff --git a/config/httpd/vhosts.d/ipfire-interface.conf b/config/httpd/vho=
sts.d/ipfire-interface.conf
> index d95fa264f..2cf57dd29 100644
> --- a/config/httpd/vhosts.d/ipfire-interface.conf
> +++ b/config/httpd/vhosts.d/ipfire-interface.conf
> @@ -9,6 +9,7 @@
>     Header always set X-Content-Type-Options nosniff
>     Header always set Content-Security-Policy "default-src 'self'; script-s=
rc 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline'"
>     Header always set Referrer-Policy strict-origin
> +    Header always set X-Frame-Options sameorigin
>=20
>     <Directory /srv/web/ipfire/html>
>         Options ExecCGI
> --=20
> 2.16.4


--===============8380398467929010487==--