From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [RFC PATCH] Drop powertop Date: Mon, 07 Nov 2022 16:44:49 +0000 Message-ID: In-Reply-To: <6831fe85-6452-73d0-c672-50d116727d11@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3042366274383700924==" List-Id: --===============3042366274383700924== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Peter, I am not quite sure what to respond to this patch. I don=E2=80=99t have any reasons to keep powertop for myself. I didn=E2=80=99= t use it in many years. However, it might be helpful to debug some hardware issues. But do people do = that these days? In order to keep the distribution small and so on, let=E2=80=99s drop it. If = someone wants it back, I wouldn=E2=80=99t mind having it back. -Michael Reviewed-by: Michael Tremer > On 7 Nov 2022, at 12:24, Peter M=C3=BCller wro= te: >=20 > This has been discussed briefly in the telephone conference of > September: powertop is considered to be unnecessary, as IPFire is > optimized for performance, thus interfering with possible power > consumption reducing switches. Also, the need for powertop has been > diminished, given that x86 platforms are highly likely not to run on > batteries, and we are phasing out 32-bit ARM, where this could have been > the case. >=20 > Therefore, this patch proposes to drop powertop. >=20 > Signed-off-by: Peter M=C3=BCller > --- > config/rootfiles/packages/powertop | 23 -------- > lfs/powertop | 90 ------------------------------ > make.sh | 1 - > 3 files changed, 114 deletions(-) > delete mode 100644 config/rootfiles/packages/powertop > delete mode 100644 lfs/powertop >=20 > diff --git a/config/rootfiles/packages/powertop b/config/rootfiles/packages= /powertop > deleted file mode 100644 > index 3ec61dd8e..000000000 > --- a/config/rootfiles/packages/powertop > +++ /dev/null > @@ -1,23 +0,0 @@ > -usr/sbin/powertop > -#usr/share/bash-completion/completions/powertop > -#usr/share/locale/ca/LC_MESSAGES/powertop.mo > -#usr/share/locale/cs_CZ/LC_MESSAGES/powertop.mo > -#usr/share/locale/de_DE > -#usr/share/locale/de_DE/LC_MESSAGES > -#usr/share/locale/de_DE/LC_MESSAGES/powertop.mo > -#usr/share/locale/en_GB/LC_MESSAGES/powertop.mo > -#usr/share/locale/en_US/LC_MESSAGES/powertop.mo > -#usr/share/locale/es_ES > -#usr/share/locale/es_ES/LC_MESSAGES > -#usr/share/locale/es_ES/LC_MESSAGES/powertop.mo > -#usr/share/locale/hu_HU > -#usr/share/locale/hu_HU/LC_MESSAGES > -#usr/share/locale/hu_HU/LC_MESSAGES/powertop.mo > -#usr/share/locale/id_ID > -#usr/share/locale/id_ID/LC_MESSAGES > -#usr/share/locale/id_ID/LC_MESSAGES/powertop.mo > -#usr/share/locale/nl_NL > -#usr/share/locale/nl_NL/LC_MESSAGES > -#usr/share/locale/nl_NL/LC_MESSAGES/powertop.mo > -#usr/share/locale/zh_TW/LC_MESSAGES/powertop.mo > -#usr/share/man/man8/powertop.8 > diff --git a/lfs/powertop b/lfs/powertop > deleted file mode 100644 > index c909a73bf..000000000 > --- a/lfs/powertop > +++ /dev/null > @@ -1,90 +0,0 @@ > -##########################################################################= ##### > -# = # > -# IPFire.org - A linux based firewall = # > -# Copyright (C) 2007-2018 IPFire Team = # > -# = # > -# This program is free software: you can redistribute it and/or modify = # > -# it under the terms of the GNU General Public License as published by = # > -# the Free Software Foundation, either version 3 of the License, or = # > -# (at your option) any later version. = # > -# = # > -# This program is distributed in the hope that it will be useful, = # > -# but WITHOUT ANY WARRANTY; without even the implied warranty of = # > -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the = # > -# GNU General Public License for more details. = # > -# = # > -# You should have received a copy of the GNU General Public License = # > -# along with this program. If not, see . = # > -# = # > -##########################################################################= ##### > - > -##########################################################################= ##### > -# Definitions > -##########################################################################= ##### > - > -include Config > - > -SUMMARY =3D A Linux Tool to Find out What is Using Power on a Laptop > - > -VER =3D 2.14 > - > -THISAPP =3D powertop-$(VER) > -DL_FILE =3D $(THISAPP).tar.gz > -DL_FROM =3D $(URL_IPFIRE) > -DIR_APP =3D $(DIR_SRC)/$(THISAPP) > -TARGET =3D $(DIR_INFO)/$(THISAPP) > -PROG =3D powertop > -PAK_VER =3D 4 > - > -DEPS =3D > - > -SERVICES =3D > - > -##########################################################################= ##### > -# Top-level Rules > -##########################################################################= ##### > - > -objects =3D $(DL_FILE) > - > -$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) > - > -$(DL_FILE)_BLAKE2 =3D 5f53f81b01e83004f6436f497818d2a552b5e7ffda5007749aad= 415773adeab2a256aeffbacbf9e5fe803ff343a0c1954b5264aebdffa841bb70406b8b9611bc > - > -install : $(TARGET) > - > -check : $(patsubst %,$(DIR_CHK)/%,$(objects)) > - > -download :$(patsubst %,$(DIR_DL)/%,$(objects)) > - > -b2 : $(subst %,%_BLAKE2,$(objects)) > - > -dist: > - $(PAK) > - > -##########################################################################= ##### > -# Downloading, checking, b2sum > -##########################################################################= ##### > - > -$(patsubst %,$(DIR_CHK)/%,$(objects)) : > - @$(CHECK) > - > -$(patsubst %,$(DIR_DL)/%,$(objects)) : > - @$(LOAD) > - > -$(subst %,%_BLAKE2,$(objects)) : > - @$(B2SUM) > - > -##########################################################################= ##### > -# Installation Details > -##########################################################################= ##### > - > -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > - @$(PREBUILD) > - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE) > - $(UPDATE_AUTOMAKE) > - cd $(DIR_APP) && ./autogen.sh > - cd $(DIR_APP) && ./configure --prefix=3D/usr > - cd $(DIR_APP) && make $(MAKETUNING) > - cd $(DIR_APP) && make install > - @rm -rf $(DIR_APP) > - @$(POSTBUILD) > diff --git a/make.sh b/make.sh > index 58220d046..ce88d9c19 100755 > --- a/make.sh > +++ b/make.sh > @@ -1592,7 +1592,6 @@ buildipfire() { > lfsmake2 zerofree > lfsmake2 minicom > lfsmake2 ddrescue > - lfsmake2 powertop > lfsmake2 parted > lfsmake2 swig > lfsmake2 dtc > --=20 > 2.35.3 --===============3042366274383700924==--