Core 136: Calamaris proxy reports stay empty

Core 136: Calamaris proxy reports stay empty

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

Hi,

after not using the "Proxy Reports" for a while, I wanted to try the
again today.

But no matter what I try, 'Calamaris' only creates *empty* logs with 0
Bytes, like '/var/ipfire/proxy/calamaris/reports/calamaris-1573395239.log'.

And the "Proxy Reports" GUI keeps telling me "No reports available".

Tested on Core 134 (Worked!), a running Core 136 installation
(Productive) and a fresh Core 136 installation. Both Core 136
installations won't work. Not at all!

I tested on console and got the following error:

...
root(a)ipfire: ~ # /usr/bin/perl /var/ipfire/proxy/calamaris/bin/mkreport
1 0 2019 8 10 2019 -d 10 -P 30 -t 10 -D 2 -u -r -1 -R 100 -s
Can't use 'defined(%hash)' (Maybe you should just omit the defined()?)
at /var/ipfire/proxy/calamaris/bin/calamaris line 2609.
...

Before I file a bug report: can anyone confirm?

Best,
Matthias

Re: Core 136: Calamaris proxy reports stay empty

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

Hi,

> On 10 Nov 2019, at 14:47, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Hi,
> 
> after not using the "Proxy Reports" for a while, I wanted to try the
> again today.
> 
> But no matter what I try, 'Calamaris' only creates *empty* logs with 0
> Bytes, like '/var/ipfire/proxy/calamaris/reports/calamaris-1573395239.log'.
> 
> And the "Proxy Reports" GUI keeps telling me "No reports available".
> 
> Tested on Core 134 (Worked!), a running Core 136 installation
> (Productive) and a fresh Core 136 installation. Both Core 136
> installations won't work. Not at all!
> 
> I tested on console and got the following error:
> 
> ...
> root(a)ipfire: ~ # /usr/bin/perl /var/ipfire/proxy/calamaris/bin/mkreport
> 1 0 2019 8 10 2019 -d 10 -P 30 -t 10 -D 2 -u -r -1 -R 100 -s
> Can't use 'defined(%hash)' (Maybe you should just omit the defined()?)
> at /var/ipfire/proxy/calamaris/bin/calamaris line 2609.

Did you try changing this line as suggested?

It is probably a regression from the Perl upgrade.

> ...
> 
> Before I file a bug report: can anyone confirm?
> 
> Best,
> Matthias

Re: Core 136: Calamaris proxy reports stay empty

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1967 bytes --]

Matthias, you are not copying the list any more in most of your emails...

> On 12 Nov 2019, at 19:05, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Hi,
> 
> On 12.11.2019 13:53, Michael Tremer wrote:
>> Hi,
>> 
>>> On 11 Nov 2019, at 17:17, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>> 
>>> On 11.11.2019 14:14, Michael Tremer wrote:
>>>> ...
>>>> Did you try changing this line as suggested?
>>> 
>>> No, because I'm not that familiar with Perl. How would I do this?
>>> 
>>> Line 2609ff reads:
>>> 
>>> ...
>>> if ( defined(%tcp_content) ) {
>> 
>> I think this line should just be:
>> 
>> if (%tcp_content) {
> 
> Done.
> 
> Tested.
> 
> Worked on both machines.
> 
> Thanks. ;-)

Cool. Please submit a patch which we can release as a quick bug fix.

>> You might have more of those in the file, but I am sure the interpreter will tell you when you try to run it.
>> 
>> As far as I know this whole calamaris thing is not maintained upstream any more. If this isn’t easily fixable we will just have to remove the feature. Not sure how many users this has.
> 
> The last version is 2.99.4.5 (V3-beta) from 2015. I took a quick look
> and there are a *lot* of changes. Hm!
> 
> Demo-Screenshots:
> https://cord.de/files/calamaris/calamaris-3/
> https://cord.de/files/calamaris/calamaris-3-frame/

This is the HTML report. I am not sure if our version could generate those, but text is obviously easier.

> But I don't know if I can handle this - looks complicated - and I'd like
> to make a possible update dependent on the number of seriously
> interested users.

Yeah, I suppose if a drop-in replacement works we can ship it. Otherwise it is not worth the effort. We have so many other things that are more important and more people would benefit from.

> Or I just send a patch with the above change.

Yes, please do.

> 
> Anyone? Opinions?
> 
> Best,
> Matthias

Re: Core 136: Calamaris proxy reports stay empty

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On 13.11.2019 17:58, Michael Tremer wrote:
> Matthias, you are not copying the list any more in most of your emails...
> ...

Ouch. I see.

Sorry. Weary head + wrong button. :-(