From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Core Update 147 testing
Date: Mon, 06 Jul 2020 15:20:59 +0100
Message-ID: <DF0020AE-C7D8-43C4-ACB4-AFB29ED7423D@ipfire.org>
In-Reply-To: <07ae3ab4-2150-f1e4-1c91-9fc6b5fb7434@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5355187050184927779=="
List-Id: <development.lists.ipfire.org>

--===============5355187050184927779==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Yes, this is handled by pakfire, the package management system.

Best,
-Michael

> On 6 Jul 2020, at 12:34, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>=20
> Hi Michael,
>=20
> I managed to answer my own question. I went and looked at the Core Update 1=
47 testing bacula install that I carried out and found a bacula file in /opt/=
pakfire/db/rootfiles/ so it does occur automatically when the add-on is insta=
lled.
>=20
> I will send the corrected bacula-9.6.5 patch file by git send-email.
>=20
> Regards,
>=20
> Adolf.
>=20
>=20
> On 04/07/2020 15:04, Adolf Belka wrote:
>> Hi Michael,
>>=20
>> I am nearly ready to git send-email but I have thought of another question=
 about something I may have missed.
>>=20
>> For removing all files during an uninstall there needs to be the rootfiles=
 list in /opt/pakfire/db/rootfiles/.
>>=20
>> Is this something that is done automatically when the add-on is installed =
or do I need to also add this as a command into lfs/bacula. If the latter the=
n where do I need to install it from. If the former then I can git send-email=
 what I have now.
>>=20
>> Regards,
>>=20
>> Adolf.
>>=20
>> On 03/07/2020 14:44, Michael Tremer wrote:
>>> Hi,
>>>=20
>>>> On 3 Jul 2020, at 12:20, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>>>=20
>>>> Hi Michael,
>>>>=20
>>>> Thanks for the information. I had missed the need to do that when I inst=
alled an updated bacula as a local add-on. The whole backup file requirement =
isn't mentioned in the Wiki page on installing your own add-on. I will think =
about maybe updating or rewriting that page using the bacula package as an ex=
ample.
>>> Yes, it is a good idea to add it.
>>>=20
>>> I am not sure in what way this needs a total rewrite.
>>>=20
>>>> I will correct my files and submit a new patch. Do I make the patch base=
d on the existing Core 146 9.0.6 version (so a v3 version of the patch) or on=
 the Core 147 development build?
>>> Yes, please make the patch against the next branch in the main repository.
>>>=20
>>> Start with a clean branch based on origin/next and add your commits. Then=
 send the whole thing to the list using git send-email.
>>>=20
>>> If you have any questions, don=E2=80=99t hesitate to ask :)
>>>=20
>>> -Michael
>>>=20
>>>>=20
>>>> Regards,
>>>>=20
>>>> Adolf.
>>>>=20
>>>> On 03/07/2020 11:36, Michael Tremer wrote:
>>>>> Hi Adolf,
>>>>>=20
>>>>> This looks like a simple problem.
>>>>>=20
>>>>> The file is simply missing in the root file:
>>>>>=20
>>>>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dconfig/rootfile=
s/packages/bacula;h=3D4ee408fc4154c56549bb7456f6e5be03791d48a2;hb=3DHEAD
>>>>>=20
>>>>> It should be listed there. Like here for example:
>>>>>=20
>>>>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dconfig/rootfile=
s/packages/postfix;h=3D23e1efb255ceb5636117bf2907dce637756c83e9;hb=3DHEAD
>>>>>=20
>>>>> lfs/bacula doesn=E2=80=99t install the file either, like Postfix does:
>>>>>=20
>>>>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dlfs/postfix;h=
=3D6ca3b23e93946c92d967bbbd23ec57d96883856b;hb=3DHEAD
>>>>>=20
>>>>> You can simply copy that command from postfix (of course change it to t=
he right name), add it to the root file and then submit a patch :)
>>>>>=20
>>>>> Best,
>>>>> -Michael
>>>>>=20
>>>>>> On 3 Jul 2020, at 00:20, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>>>>>=20
>>>>>> Dear All,
>>>>>>=20
>>>>>> I went back to a Core Update 146 system and installed the old bacula 9=
.0.6 and found that version also had no backup include file in place, althoug=
h it did exist in the config/backup/includes directory from the git clone.
>>>>>>=20
>>>>>> Adolf
>>>>>>=20
>>>>>>=20
>>>>>> On 03/07/2020 00:11, Adolf Belka wrote:
>>>>>>> Dear All,
>>>>>>>=20
>>>>>>> I have tested Core Update 147 out on my virtual ipfire test bed netwo=
rk.
>>>>>>>=20
>>>>>>> I also tested out installing bacula with its new version. It installe=
d okay and started successfully. To test it out fully I will need to do the t=
est on my production system.
>>>>>>>=20
>>>>>>> However I found one problem. The /var/ipfire/backup/addons/includes/b=
acula file is not there. There is no includes directory under addons and the =
bacula option is not there in the backup menu in the WUI.
>>>>>>>=20
>>>>>>> Probably something I did wrong in how I did my patch but I don't know=
 what the problem is. The patch included the config/backup/includes/bacula fi=
le. Could someone figure out what the problem is.
>>>>>>>=20
>>>>>>> Apart from the problem with the bacula addon backup option not being =
present everything else on my testbed with update 147 is working fine, althou=
gh it is not a complicated setup. Just red, green, blue and orange but no oth=
er options yet.
>>>>>>>=20
>>>>>>> Adolf.
>>>>>>>=20


--===============5355187050184927779==--