Re: [PATCH] dmidecode: update to 3.2

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]

Hello,

This patch has a couple of issues.

> On 5 Jan 2019, at 10:47, Peter Müller <peter.mueller(a)link38.eu> wrote:
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> dmidecode/dmidecode.nm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/dmidecode/dmidecode.nm b/dmidecode/dmidecode.nm
> index 828924367..05f9537bb 100644
> --- a/dmidecode/dmidecode.nm
> +++ b/dmidecode/dmidecode.nm
> @@ -4,11 +4,11 @@
> ###############################################################################
> 
> name       = dmidecode
> -version    = 3.0
> -release    = 1
> +version    = 3.2
> +release    = 2

In contrast to IPFire 2, please restart the release again from 1 when version is being updated.

> groups     = Applications/System
> -url        = http://www.nongnu.org/dmidecode/
> +url        = https://www.nongnu.org/dmidecode/
> license    = GPLv2+
> summary    = Tool to analyse BIOS DMI data.
> 
> @@ -21,7 +21,7 @@ description
> 	manufacturer.
> end
> 
> -source_dl  = http://download.savannah.gnu.org/releases/dmidecode/
> +source_dl  = https://download.savannah.gnu.org/releases/dmidecode/

HTTPS is good, but the source is not available in tar.gz format. Therefore this does not build.

You will need to overwrite “sources” to download the tar.xz version of dmidecode.

> build
> 	make_build_targets += CFLAGS="%{CFLAGS}" LDFLAGS="%{LDFLAGS}"
> -- 
> 2.16.4

Best,
-Michael