From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] kernel: reset asix88179 twice like in older kernels
Date: Tue, 04 Jun 2024 13:43:44 +0100
Message-ID: <DFEFF5F1-B0F0-4716-B00B-0CF6EA048C41@ipfire.org>
In-Reply-To: <20240604120853.2327-1-arne_f@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3889925082645008805=="
List-Id: <development.lists.ipfire.org>

--===============3889925082645008805==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Could you please make sure to report this upstream so that this fix gets incl=
uded in mainline?

Best,
-Michael

> On 4 Jun 2024, at 13:08, Arne Fitzenreiter <arne_f(a)ipfire.org> wrote:
>=20
> the kernel developers has removed a reset at bring the
> device fist up to save time. At my test's this result in
> not detecting the link correct. This readd the reset and at
> my tests the device has worked.
>=20
> fixes #13692
>=20
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
> lfs/linux                                       |  3 +++
> .../linux/linux-6.6.32-asix88179_reset.patch    | 17 +++++++++++++++++
> 2 files changed, 20 insertions(+)
> create mode 100644 src/patches/linux/linux-6.6.32-asix88179_reset.patch
>=20
> diff --git a/lfs/linux b/lfs/linux
> index ca3b05119..3f5e60838 100644
> --- a/lfs/linux
> +++ b/lfs/linux
> @@ -133,6 +133,9 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> # https://bugzilla.ipfire.org/show_bug.cgi?id=3D12760
> cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux/linux-5.15-NFQUE=
UE-Hold-RCU-read-lock-while-calling-nf_reinject.patch
>=20
> + # reset ax88179 twice like in older kernels
> + cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux/linux-6.6.32-a=
six88179_reset.patch
> +
> # Fix external module compile
> cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux/linux-6.0-fix_ex=
ternal_module_build.patch
>=20
> diff --git a/src/patches/linux/linux-6.6.32-asix88179_reset.patch b/src/pat=
ches/linux/linux-6.6.32-asix88179_reset.patch
> new file mode 100644
> index 000000000..f0e7d09f1
> --- /dev/null
> +++ b/src/patches/linux/linux-6.6.32-asix88179_reset.patch
> @@ -0,0 +1,17 @@
> +diff -Naur linux-6.6.32.org/drivers/net/usb/ax88179_178a.c linux-6.6.32/dr=
ivers/net/usb/ax88179_178a.c
> +--- linux-6.6.32.org/drivers/net/usb/ax88179_178a.c 2024-05-25 16:22:56.00=
0000000 +0200
> ++++ linux-6.6.32/drivers/net/usb/ax88179_178a.c 2024-06-04 10:45:18.113453=
100 +0200
> +@@ -1678,10 +1678,10 @@
> + {
> + struct ax88179_data *ax179_data =3D dev->driver_priv;
> +=20
> +- if (ax179_data->initialized)
> ++// if (ax179_data->initialized)
> + ax88179_reset(dev);
> +- else
> +- ax179_data->initialized =3D 1;
> ++// else
> ++// ax179_data->initialized =3D 1;
> +=20
> + return 0;
> + }
> --=20
> 2.39.2
>=20


--===============3889925082645008805==--