Re: [PATCH] igmpproxy: Update to version 0.3

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 5814 bytes --]

Hello,

> On 5 Aug 2021, at 13:36, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 04/08/2021 16:24, Michael Tremer wrote:
>> Hello,
>> I cannot find this any more, but I thought I read that newer versions of igmpproxy are no longer compatible with some streaming services because they removed support for older versions of IGMP.
>> Do I remember this correctly? Is anybody able to test this? I am not sure if this is working at all.
> I haven't been able to find anything on this. The changes I listed are all the ones defined from the current version to version 0.3 and none of those seem have a relation to removing support from older versions of IGMP. Of course that also doesn't mean that it hasn't been.
> 
> I looked in the IPFire wiki on this addon. The link to T-Home no longer works. It looks like Deutsche Telekom EntertainTV has become MagentaTV.

Yes, it has been rebranded a couple of times and I am not sure whether anything else has been changed on the tech side.

> Looking through the help with connecting routers to their system there didn't seem to be any related to any router than Speedport or FritzBox.
> 
> Anyway, I don't think I can help on this topic further. I certainly can't test it in use.

Same. We could either ship the update and hope for the best or remove it altogether if nobody is interested in supporting this.

> If no one responds that is able to test it then maybe we have to leave it at the previous version which is from 2018 so not too old.

-Michael

> Regards,
> Adolf.
> 
>> Best,
>> -Michael
>>> On 31 Jul 2021, at 21:05, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> - Update from 0.2.1 to 0.3
>>> - Update of rootfile not required
>>> - Changelog
>>>   2021-01-04 18:40:01 +0100  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Release version 0.3
>>>   2020-09-05 13:52:50 +0200  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Remove duplicate code in mcgroup.c file
>>>           Existing functionality is provided by k_join and k_leave functions.
>>>   2020-09-05 13:07:38 +0200  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Fix initialization and deinitialization of mrouter socket
>>>           Ensure that uninitialized socket is invalid (-1) and not stdin (0).
>>>   2020-09-05 13:07:00 +0200  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Use main mrouter socket also for sending join/leave messages to upstream router
>>>           There is no need to open additional UDP socket which is used just for calling
>>> 	    IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP setsockopt. Main mrouter socket is can
>>> 	    be used for these operations too.
>>>   2020-05-20 09:59:11 +0200  Uglymotha <uglymotha(a)wizdom.nu>
>>> 	* Free BSD Compilation Patch
>>>           On FreeBSD compilation failed due to missing includes in os-freebsd.h.
>>>            This was causing errors about undefined structs and types in missing includes.
>>>            Also defines __BSD_VISIBLE due to FreeBSD not providing u_int, u_long etc
>>>            in a default _POSIX_C_SOURCE environment.
>>>           Fixes: https://github.com/pali/igmpproxy/issues/68
>>>   2020-05-08 22:54:06 +0200  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Remove MAX_MC_VIFS macro
>>>           Its value is same as MAXVIFS, so use MAXVIFS instead.
>>>   2020-03-06 11:51:21 +0100  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Improve downstream host tracking for quickleave mode
>>>           Use bit based per multicast route hash table for tracking downstream hosts.
>>> 	   For hasing function is used 32bit MurmurHash3 with pseudorandom seed and
>>> 	   size of hash table can be configured via a new "hashtablesize" token in
>>> 	   config file. Default size of hash table is 32 bytes, so it can store
>>> 	   approximatelly 128 hosts which is half of /24 subnet. For home networks
>>> 	   this should be sane default value.
>>> 	  Fixes: https://github.com/pali/igmpproxy/pull/57
>>>   2020-02-26 20:27:08 +0100  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Show error message when IP_ADD_MEMBERSHIP fails with errno ENOBUFS
>>> 	   Also on Linux show hint how to increase maximum number of multicast groups.
>>> 	  Fixes: https://github.com/pali/igmpproxy/issues/30
>>>   2020-02-25 23:46:57 +0100  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Fix gcc-7 and clang-9 on Travis
>>>   2020-02-25 23:24:26 +0100  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Update Travis config file
>>>   2019-06-26 17:42:15 +0200  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Use AS_IF macro for C99 check in configure.ac
>>>   2018-09-30 00:28:05 +0200  Pali Rohár <pali.rohar(a)gmail.com>
>>> 	* Fix makefile rules for generating AUTHORS and ChangeLog files
>>>   2018-02-13 20:17:30 +0100  Pali Rohár <pali.rohar(a)gmail.com>
>>> 
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>> lfs/igmpproxy | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/lfs/igmpproxy b/lfs/igmpproxy
>>> index c32d519b9..bd6407bdc 100644
>>> --- a/lfs/igmpproxy
>>> +++ b/lfs/igmpproxy
>>> @@ -24,7 +24,7 @@
>>> 
>>> include Config
>>> 
>>> -VER        = 0.2.1
>>> +VER        = 0.3
>>> 
>>> THISAPP    = igmpproxy-$(VER)
>>> DL_FILE    = $(THISAPP).tar.gz
>>> @@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
>>> DIR_APP    = $(DIR_SRC)/$(THISAPP)
>>> TARGET     = $(DIR_INFO)/$(THISAPP)
>>> PROG       = igmpproxy
>>> -PAK_VER    = 5
>>> +PAK_VER    = 6
>>> 
>>> DEPS       =
>>> 
>>> @@ -44,7 +44,7 @@ objects = $(DL_FILE)
>>> 
>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>> 
>>> -$(DL_FILE)_MD5 = 3a9c2cb42c1f5ee0cb769a4884545641
>>> +$(DL_FILE)_MD5 = 5565874d9631103109a72452cecb5ce7
>>> 
>>> install : $(TARGET)
>>> 
>>> -- 
>>> 2.32.0
>>>