From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jon Murphy <jcmurphy26@gmail.com>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2] tftpd: add missing directory
Date: Mon, 01 Aug 2022 10:26:42 -0500
Message-ID: <E4EBCAAE-996C-4111-9EC4-82BD4B5CC089@gmail.com>
In-Reply-To: <20220801151122.854266-1-jon.murphy@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2767061391843596147=="
List-Id: <development.lists.ipfire.org>

--===============2767061391843596147==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Peter and *,

I am not sure if I did this correctly or not. =20

As best as I can tell I can add the `mkdir -pv /var/tftpboot` to:
- The tftpd LFS file
- The tftpd ROOTFILES file (as just `/var/tftpboot`)
- And/or the tftpd `install.sh` file

But I am not sure why I should pick one over the others=E2=80=A6


Jon

> On Aug 1, 2022, at 10:11 AM, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
>=20
> - starting tftpd currently throws "missing directory" error
> - this change corrects the issue
>=20
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
> config/rootfiles/packages/tftpd | 1 +
> lfs/tftpd                       | 5 +++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/rootfiles/packages/tftpd b/config/rootfiles/packages/tf=
tpd
> index 377f8a21e..da19f46a0 100644
> --- a/config/rootfiles/packages/tftpd
> +++ b/config/rootfiles/packages/tftpd
> @@ -4,3 +4,4 @@ usr/sbin/tftpd
> #usr/share/man/man1/tftp.1
> #usr/share/man/man8/in.tftpd.8
> #usr/share/man/man8/tftpd.8
> +var/tftpboot
> diff --git a/lfs/tftpd b/lfs/tftpd
> index cb3d03415..f441c499c 100644
> --- a/lfs/tftpd
> +++ b/lfs/tftpd
> @@ -1,7 +1,7 @@
> ###########################################################################=
####
> #                                                                          =
   #
> # IPFire.org - A linux based firewall                                      =
   #
> -# Copyright (C) 2007-2021  IPFire Team  <info(a)ipfire.org>               =
      #
> +# Copyright (C) 2007-2022  IPFire Team  <info(a)ipfire.org>               =
      #
> #                                                                          =
   #
> # This program is free software: you can redistribute it and/or modify     =
   #
> # it under the terms of the GNU General Public License as published by     =
   #
> @@ -34,7 +34,7 @@ DL_FROM    =3D $(URL_IPFIRE)
> DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
> TARGET     =3D $(DIR_INFO)/$(THISAPP)
> PROG       =3D tftpd
> -PAK_VER    =3D 2
> +PAK_VER    =3D 3
>=20
> DEPS       =3D
>=20
> @@ -87,6 +87,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> 	cd $(DIR_APP) && make $(MAKETUNING)
> 	cd $(DIR_APP) && make install
> 	mv -fv /usr/sbin/in.tftpd /usr/sbin/tftpd
> +	mkdir -pv /var/tftpboot
> 	#install initscripts
> 	$(call INSTALL_INITSCRIPTS,$(SERVICES))
> 	@rm -rf $(DIR_APP)
> --=20
> 2.30.2
>=20


--===============2767061391843596147==--