* [PATCH] tftpd: add missing directory
@ 2022-07-23 16:14 Jon Murphy
2022-07-24 12:52 ` Peter Müller
2022-08-01 15:11 ` [PATCH v2] " Jon Murphy
0 siblings, 2 replies; 5+ messages in thread
From: Jon Murphy @ 2022-07-23 16:14 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]
- starting tftpd currently throws "missing directory" error
- this change corrects the issue
Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
---
lfs/tftpd | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lfs/tftpd b/lfs/tftpd
index cb3d03415..f441c499c 100644
--- a/lfs/tftpd
+++ b/lfs/tftpd
@@ -1,7 +1,7 @@
###############################################################################
# #
# IPFire.org - A linux based firewall #
-# Copyright (C) 2007-2021 IPFire Team <info(a)ipfire.org> #
+# Copyright (C) 2007-2022 IPFire Team <info(a)ipfire.org> #
# #
# This program is free software: you can redistribute it and/or modify #
# it under the terms of the GNU General Public License as published by #
@@ -34,7 +34,7 @@ DL_FROM = $(URL_IPFIRE)
DIR_APP = $(DIR_SRC)/$(THISAPP)
TARGET = $(DIR_INFO)/$(THISAPP)
PROG = tftpd
-PAK_VER = 2
+PAK_VER = 3
DEPS =
@@ -87,6 +87,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
cd $(DIR_APP) && make $(MAKETUNING)
cd $(DIR_APP) && make install
mv -fv /usr/sbin/in.tftpd /usr/sbin/tftpd
+ mkdir -pv /var/tftpboot
#install initscripts
$(call INSTALL_INITSCRIPTS,$(SERVICES))
@rm -rf $(DIR_APP)
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tftpd: add missing directory
2022-07-23 16:14 [PATCH] tftpd: add missing directory Jon Murphy
@ 2022-07-24 12:52 ` Peter Müller
2022-07-24 17:13 ` Jon Murphy
2022-08-01 15:11 ` [PATCH v2] " Jon Murphy
1 sibling, 1 reply; 5+ messages in thread
From: Peter Müller @ 2022-07-24 12:52 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]
Hello Jon,
thank you for submitting this.
Just a quick question: With regards to the tftpd rootfile (which currently does not
include /var/tftpboot), isn't this change necessary during installation of the add-on
(as well)? I. e., shouldn't this go into the installation script of the add-on?
Or did I got this wrong?
Thanks, and best regards,
Peter Müller
> - starting tftpd currently throws "missing directory" error
> - this change corrects the issue
>
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
> lfs/tftpd | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lfs/tftpd b/lfs/tftpd
> index cb3d03415..f441c499c 100644
> --- a/lfs/tftpd
> +++ b/lfs/tftpd
> @@ -1,7 +1,7 @@
> ###############################################################################
> # #
> # IPFire.org - A linux based firewall #
> -# Copyright (C) 2007-2021 IPFire Team <info(a)ipfire.org> #
> +# Copyright (C) 2007-2022 IPFire Team <info(a)ipfire.org> #
> # #
> # This program is free software: you can redistribute it and/or modify #
> # it under the terms of the GNU General Public License as published by #
> @@ -34,7 +34,7 @@ DL_FROM = $(URL_IPFIRE)
> DIR_APP = $(DIR_SRC)/$(THISAPP)
> TARGET = $(DIR_INFO)/$(THISAPP)
> PROG = tftpd
> -PAK_VER = 2
> +PAK_VER = 3
>
> DEPS =
>
> @@ -87,6 +87,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> cd $(DIR_APP) && make $(MAKETUNING)
> cd $(DIR_APP) && make install
> mv -fv /usr/sbin/in.tftpd /usr/sbin/tftpd
> + mkdir -pv /var/tftpboot
> #install initscripts
> $(call INSTALL_INITSCRIPTS,$(SERVICES))
> @rm -rf $(DIR_APP)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tftpd: add missing directory
2022-07-24 12:52 ` Peter Müller
@ 2022-07-24 17:13 ` Jon Murphy
0 siblings, 0 replies; 5+ messages in thread
From: Jon Murphy @ 2022-07-24 17:13 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2589 bytes --]
Peter,
Since I am still learning I must defer to you. I had assumed (bad word!) the
`mkdir -pv /var/tftpboot` below would have done both.
> shouldn't this go into the installation script of the add-on?
I think the answer is "yes".
Is the `mkdir -pv /var/tftpboot` below for the make build phase only?
If `mkdir -pv /var/tftpboot` belongs in the `install.sh` script then I can add it.
And I can remove the `mkdir -pv /var/tftpboot` from the LFS file.
Your guidance is needed!
Jon
> On Jul 24, 2022, at 7:52 AM, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Hello Jon,
>
> thank you for submitting this.
>
> Just a quick question: With regards to the tftpd rootfile (which currently does not
> include /var/tftpboot), isn't this change necessary during installation of the add-on
> (as well)? I. e., shouldn't this go into the installation script of the add-on?
>
> Or did I got this wrong?
>
> Thanks, and best regards,
> Peter Müller
>
>
>> - starting tftpd currently throws "missing directory" error
>> - this change corrects the issue
>> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
>> ---
>> lfs/tftpd | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>> diff --git a/lfs/tftpd b/lfs/tftpd
>> index cb3d03415..f441c499c 100644
>> --- a/lfs/tftpd
>> +++ b/lfs/tftpd
>> @@ -1,7 +1,7 @@
>> ###############################################################################
>> # #
>> # IPFire.org - A linux based firewall #
>> -# Copyright (C) 2007-2021 IPFire Team <info(a)ipfire.org> #
>> +# Copyright (C) 2007-2022 IPFire Team <info(a)ipfire.org> #
>> # #
>> # This program is free software: you can redistribute it and/or modify #
>> # it under the terms of the GNU General Public License as published by #
>> @@ -34,7 +34,7 @@ DL_FROM = $(URL_IPFIRE)
>> DIR_APP = $(DIR_SRC)/$(THISAPP)
>> TARGET = $(DIR_INFO)/$(THISAPP)
>> PROG = tftpd
>> -PAK_VER = 2
>> +PAK_VER = 3
>> DEPS =
>> @@ -87,6 +87,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>> cd $(DIR_APP) && make $(MAKETUNING)
>> cd $(DIR_APP) && make install
>> mv -fv /usr/sbin/in.tftpd /usr/sbin/tftpd
>> + mkdir -pv /var/tftpboot
>> #install initscripts
>> $(call INSTALL_INITSCRIPTS,$(SERVICES))
>> @rm -rf $(DIR_APP)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] tftpd: add missing directory
2022-07-23 16:14 [PATCH] tftpd: add missing directory Jon Murphy
2022-07-24 12:52 ` Peter Müller
@ 2022-08-01 15:11 ` Jon Murphy
2022-08-01 15:26 ` Jon Murphy
1 sibling, 1 reply; 5+ messages in thread
From: Jon Murphy @ 2022-08-01 15:11 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]
- starting tftpd currently throws "missing directory" error
- this change corrects the issue
Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
---
config/rootfiles/packages/tftpd | 1 +
lfs/tftpd | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/config/rootfiles/packages/tftpd b/config/rootfiles/packages/tftpd
index 377f8a21e..da19f46a0 100644
--- a/config/rootfiles/packages/tftpd
+++ b/config/rootfiles/packages/tftpd
@@ -4,3 +4,4 @@ usr/sbin/tftpd
#usr/share/man/man1/tftp.1
#usr/share/man/man8/in.tftpd.8
#usr/share/man/man8/tftpd.8
+var/tftpboot
diff --git a/lfs/tftpd b/lfs/tftpd
index cb3d03415..f441c499c 100644
--- a/lfs/tftpd
+++ b/lfs/tftpd
@@ -1,7 +1,7 @@
###############################################################################
# #
# IPFire.org - A linux based firewall #
-# Copyright (C) 2007-2021 IPFire Team <info(a)ipfire.org> #
+# Copyright (C) 2007-2022 IPFire Team <info(a)ipfire.org> #
# #
# This program is free software: you can redistribute it and/or modify #
# it under the terms of the GNU General Public License as published by #
@@ -34,7 +34,7 @@ DL_FROM = $(URL_IPFIRE)
DIR_APP = $(DIR_SRC)/$(THISAPP)
TARGET = $(DIR_INFO)/$(THISAPP)
PROG = tftpd
-PAK_VER = 2
+PAK_VER = 3
DEPS =
@@ -87,6 +87,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
cd $(DIR_APP) && make $(MAKETUNING)
cd $(DIR_APP) && make install
mv -fv /usr/sbin/in.tftpd /usr/sbin/tftpd
+ mkdir -pv /var/tftpboot
#install initscripts
$(call INSTALL_INITSCRIPTS,$(SERVICES))
@rm -rf $(DIR_APP)
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] tftpd: add missing directory
2022-08-01 15:11 ` [PATCH v2] " Jon Murphy
@ 2022-08-01 15:26 ` Jon Murphy
0 siblings, 0 replies; 5+ messages in thread
From: Jon Murphy @ 2022-08-01 15:26 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2400 bytes --]
Peter and *,
I am not sure if I did this correctly or not.
As best as I can tell I can add the `mkdir -pv /var/tftpboot` to:
- The tftpd LFS file
- The tftpd ROOTFILES file (as just `/var/tftpboot`)
- And/or the tftpd `install.sh` file
But I am not sure why I should pick one over the others…
Jon
> On Aug 1, 2022, at 10:11 AM, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
>
> - starting tftpd currently throws "missing directory" error
> - this change corrects the issue
>
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
> config/rootfiles/packages/tftpd | 1 +
> lfs/tftpd | 5 +++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/config/rootfiles/packages/tftpd b/config/rootfiles/packages/tftpd
> index 377f8a21e..da19f46a0 100644
> --- a/config/rootfiles/packages/tftpd
> +++ b/config/rootfiles/packages/tftpd
> @@ -4,3 +4,4 @@ usr/sbin/tftpd
> #usr/share/man/man1/tftp.1
> #usr/share/man/man8/in.tftpd.8
> #usr/share/man/man8/tftpd.8
> +var/tftpboot
> diff --git a/lfs/tftpd b/lfs/tftpd
> index cb3d03415..f441c499c 100644
> --- a/lfs/tftpd
> +++ b/lfs/tftpd
> @@ -1,7 +1,7 @@
> ###############################################################################
> # #
> # IPFire.org - A linux based firewall #
> -# Copyright (C) 2007-2021 IPFire Team <info(a)ipfire.org> #
> +# Copyright (C) 2007-2022 IPFire Team <info(a)ipfire.org> #
> # #
> # This program is free software: you can redistribute it and/or modify #
> # it under the terms of the GNU General Public License as published by #
> @@ -34,7 +34,7 @@ DL_FROM = $(URL_IPFIRE)
> DIR_APP = $(DIR_SRC)/$(THISAPP)
> TARGET = $(DIR_INFO)/$(THISAPP)
> PROG = tftpd
> -PAK_VER = 2
> +PAK_VER = 3
>
> DEPS =
>
> @@ -87,6 +87,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> cd $(DIR_APP) && make $(MAKETUNING)
> cd $(DIR_APP) && make install
> mv -fv /usr/sbin/in.tftpd /usr/sbin/tftpd
> + mkdir -pv /var/tftpboot
> #install initscripts
> $(call INSTALL_INITSCRIPTS,$(SERVICES))
> @rm -rf $(DIR_APP)
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-01 15:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-23 16:14 [PATCH] tftpd: add missing directory Jon Murphy
2022-07-24 12:52 ` Peter Müller
2022-07-24 17:13 ` Jon Murphy
2022-08-01 15:11 ` [PATCH v2] " Jon Murphy
2022-08-01 15:26 ` Jon Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox