From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] make.sh: Add OPTION to not clear screen
Date: Mon, 30 May 2022 09:33:23 +0100
Message-ID: <E5199F9E-B41D-4AD0-AAEA-D596A0635A20@ipfire.org>
In-Reply-To: <20220529185158.3517499-1-jon.murphy@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8249274557677742930=="
List-Id: <development.lists.ipfire.org>

--===============8249274557677742930==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Jon,

I do not quite understand how the clear makes the build harder to read.

I am happy to drop the clear entirely, because it doesn=E2=80=99t add that mu=
ch to the experience.

-Michael

> On 29 May 2022, at 19:51, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
>=20
> - minor changes to build and toolchain section
> - screen will not clear if option "--no-clear" is included
> - assists beginners (me!) view all steps in build process
>=20
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
> doc/make.sh-usage |  3 +++
> make.sh           | 10 ++++++++--
> 2 files changed, 11 insertions(+), 2 deletions(-)
>=20
> diff --git a/doc/make.sh-usage b/doc/make.sh-usage
> index 5e1e3dd22..32e7fd862 100644
> --- a/doc/make.sh-usage
> +++ b/doc/make.sh-usage
> @@ -21,3 +21,6 @@ Options:
>                                        the desired target architecture.
>                                        Can be permanently set with TARGET_A=
RCH=3D in
>                                        .config.
> +
> +    --no-clear : do not clear screen when during command build or toolchain
> +
> diff --git a/make.sh b/make.sh
> index 3ed9190b9..1e22a513b 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1803,11 +1803,17 @@ ipfirepackages() {
>   rm -rf  $BASEDIR/build/install/packages/*
> }
>=20
> +# Default setting
> +CLEAR_SCREEN=3Dtrue
> +
> while [ $# -gt 0 ]; do
> 	case "${1}" in
> 		--target=3D*)
> 			configure_build "${1#--target=3D}"
> 			;;
> +		--no-clear)
> +			CLEAR_SCREEN=3Dfalse
> +			;;
> 		-*)
> 			exiterror "Unknown configuration option: ${1}"
> 			;;
> @@ -1825,7 +1831,7 @@ build)
> 	START_TIME=3D"${SECONDS}"
>=20
> 	# Clear screen
> -	${INTERACTIVE} && clear
> +	${INTERACTIVE} && ${CLEAR_SCREEN} && clear
>=20
> 	PACKAGE=3D"$BASEDIR/cache/toolchains/$SNAME-$VERSION-toolchain-$TOOLCHAINV=
ER-${BUILD_ARCH}.tar.zst"
> 	#only restore on a clean disk
> @@ -1971,7 +1977,7 @@ downloadsrc)
> 	;;
> toolchain)
> 	# Clear screen
> -	${INTERACTIVE} && clear
> +	${INTERACTIVE} && ${CLEAR_SCREEN} && clear
>=20
> 	prepareenv
> 	print_build_stage "Toolchain compilation (${BUILD_ARCH})"
> --=20
> 2.30.2
>=20


--===============8249274557677742930==--