From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [Patch RFC 07/15] network startup: Reload routing informations
 for every interface
Date: Wed, 24 May 2023 10:00:18 +0100
Message-ID: <E6864A63-17EF-4D98-ADD9-5ACC3282CEAA@ipfire.org>
In-Reply-To: <20230523172314.7826-8-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4713182183789929815=="
List-Id: <development.lists.ipfire.org>

--===============4713182183789929815==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

This assumption is incorrect.

You could have a route that points somewhere else if a certain interface is n=
ot available (e.g. VPNs).

This is probably bad network design, but I suppose that we did support this b=
efore.

> On 23 May 2023, at 18:23, Jonatan Schlag <jonatan.schlag(a)ipfire.org> wrot=
e:
>=20
> This reload can and needs to be done when an interface is started. Not only
> when all interfaces are started.
>=20
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
> src/initscripts/networking/any | 2 ++
> src/initscripts/system/network | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/src/initscripts/networking/any b/src/initscripts/networking/any
> index 6dba5bef9..ec1321ad9 100644
> --- a/src/initscripts/networking/any
> +++ b/src/initscripts/networking/any
> @@ -109,6 +109,8 @@ case "${1}" in
> ip addr add ${args} dev ${DEVICE}
> evaluate_retval
> fi
> +
> + /etc/rc.d/init.d/static-routes reload
> ;;
>=20
> stop)
> diff --git a/src/initscripts/system/network b/src/initscripts/system/network
> index 6a47456f3..b346d487c 100644
> --- a/src/initscripts/system/network
> +++ b/src/initscripts/system/network
> @@ -66,8 +66,6 @@ case "${DO}" in
> /etc/rc.d/init.d/networking/red start
> fi
>=20
> - /etc/rc.d/init.d/static-routes start
> -
> boot_mesg "Mounting network file systems..."
> mount -a -O _netdev
> evaluate_retval
> --=20
> 2.30.2
>=20


--===============4713182183789929815==--