From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript
Date: Mon, 07 Aug 2023 11:30:46 +0200
Message-ID: <E69EC5BF-C3BD-4EA3-91B4-3405F543212C@ipfire.org>
In-Reply-To: <8f5071ac-77d2-81fb-c0a6-e3ad701ba239@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4573701484311173011=="
List-Id: <development.lists.ipfire.org>

--===============4573701484311173011==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Adolf,

As the update has been released, I would say this counts as the testing being=
 done.

-Michael

> On 2 Aug 2023, at 16:14, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> Hi All,
>=20
> On 04/07/2023 14:52, Adolf Belka wrote:
>> So next thing is to see if this updated version works for Peter and Arne o=
r if I have more work to do. :-)
>>=20
> At the last video conf call Peter and Arne mentioned that they are able to =
test a pppoe connection with the ppp version update patch I submitted at the =
beginning of July.
>=20
> https://lists.ipfire.org/pipermail/development/2023-July/016101.html
>=20
> Any progress on the testing. Just let me know if there are any issues that =
I need to work on.
>=20
> Regards,
> Adolf.
>=20
>> Regards,
>> Adolf.
>>=20
>> On 04/07/2023 11:08, Michael Tremer wrote:
>>> Thanks. This looks good to me.
>>>=20
>>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>>=20
>>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>=20
>>>> - This patch goes together with the patch for the ppp update to 2.5.0
>>>> - The rp-pppoe.so option is no longer available. There is only the pppoe=
.so available now
>>>>=20
>>>> Fixes: Bug#13164
>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>> ---
>>>> src/initscripts/networking/red | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>=20
>>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking=
/red
>>>> index 16d48f3ac..75a17bd5a 100644
>>>> --- a/src/initscripts/networking/red
>>>> +++ b/src/initscripts/networking/red
>>>> @@ -365,7 +365,7 @@ case "${1}" in
>>>> #
>>>> if [ "$TYPE" =3D=3D "pppoe" ]; then
>>>> [ "${METHOD}" =3D=3D "PPPOE_PLUGIN" ] && \
>>>> - PLUGOPTS=3D"plugin rp-pppoe.so"
>>>> + PLUGOPTS=3D"plugin pppoe.so"
>>>> fi
>>>>=20
>>>> ### Synchronous Mode
>>>> --=20
>>>> 2.41.0
>>>>=20
>>>=20
>=20
> --=20
> Sent from my laptop



--===============4573701484311173011==--