From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] libloc: Apply patch to compile the perl module without
 stack protector.
Date: Mon, 20 Jul 2020 10:23:43 +0100
Message-ID: <E990F752-8930-4822-B0EA-0049B957055B@ipfire.org>
In-Reply-To: <20200719092252.4315-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8482965344765511040=="
List-Id: <development.lists.ipfire.org>

--===============8482965344765511040==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

This isn=E2=80=99t really the best solution I would say, but it will at least=
 work for now.

I suppose there is an issue in the perl build system and that either the -fst=
ack-protector-all flag is being filtered or it links libc in a funny way.

I would propose to make this conditional to i586 because the module builds fi=
ne on all other architectures.

-Michael

P.S. Did you try adding -lssp to the linker flags?

> On 19 Jul 2020, at 10:22, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> lfs/libloc                                           |  3 +++
> .../libloc-0.9.3-perl-no-stack-protector.patch       | 12 ++++++++++++
> 2 files changed, 15 insertions(+)
> create mode 100644 src/patches/libloc-0.9.3-perl-no-stack-protector.patch
>=20
> diff --git a/lfs/libloc b/lfs/libloc
> index 43af26b45..5cf3e0819 100644
> --- a/lfs/libloc
> +++ b/lfs/libloc
> @@ -78,6 +78,9 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> 	@$(PREBUILD)
> 	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar xvf $(DIR_DL)/$(DL_FILE)
>=20
> +	# Add patch for i585 to disable the stack protector.
> +	cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/libloc-0.9.3-perl-n=
o-stack-protector.patch
> +
> 	cd $(DIR_APP) && ./autogen.sh
> 	cd $(DIR_APP) && ./configure \
> 		--prefix=3D/usr \
> diff --git a/src/patches/libloc-0.9.3-perl-no-stack-protector.patch b/src/p=
atches/libloc-0.9.3-perl-no-stack-protector.patch
> new file mode 100644
> index 000000000..b615ed902
> --- /dev/null
> +++ b/src/patches/libloc-0.9.3-perl-no-stack-protector.patch
> @@ -0,0 +1,12 @@
> +diff --git a/src/perl/Makefile.PL b/src/perl/Makefile.PL
> +index 38d5390..62016ca 100644
> +--- a/src/perl/Makefile.PL
> ++++ b/src/perl/Makefile.PL
> +@@ -11,6 +11,7 @@ WriteMakefile(
> +     LIBS              =3D> ['-lloc'],
> +     DEFINE            =3D> '', # e.g., '-DHAVE_SOMETHING'
> +     INC               =3D> '-I. -I../../',
> ++    CCFLAGS           =3D> '-fno-stack-protector',
> + 	# Un-comment this if you add C files to link with later:
> +     # OBJECT            =3D> '$(O_FILES)', # link all the C files too
> + );
> --=20
> 2.20.1
>=20


--===============8482965344765511040==--