From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH v2 1/6] zoneconf.cgi: Change NIC display order, improve code Date: Fri, 19 Feb 2021 19:26:35 +0000 Message-ID: In-Reply-To: <1d9902fa-da98-ab30-d887-fa47ed44bf3b@leo-andres.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8197403045953925053==" List-Id: --===============8197403045953925053== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, > On 18 Feb 2021, at 14:36, Leo Hofmann wrote: >=20 > Hi all, >=20 > you probably already saw this patchset last month :) >=20 > I have implemented your suggestions and decided to resubmit the entire patc= hset to keep it coherent. > The patches 1-4 are unchanged. Daniel and Michael have already tested them = (thank you very much!). >=20 > Patch 5 makes zoneconf use the new zone detection functions in network-func= tions.pl. This also fixes bug #12568! > Patch 6 adds default values to the input fields. I decided to add a default= VLAN ID as well, because these inputs suffered from the same usability issue= as the STP priority fields. >=20 > I'm looking forward to your feedback! Thank you very much for working on this. Judging from the code, this looks very good. Nice and tidy and changes are sp= lit into small chunks that are very easy to review. I will wait for some more people to give any feedback - and hopefully test it= live - and merge it. Well done! -Michael > Best regards, > Leo >=20 > P.S. @Daniel thanks for your help with re-submitting! I have read through a= ll your emails again and decided that I can submit these patches now. >=20 --===============8197403045953925053==--