From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] BUG12445: Fix for Hyper-V stuck 8 minutes at boot Date: Thu, 01 Apr 2021 10:32:38 +0100 Message-ID: In-Reply-To: <20210331224236.12971-1-admin@cekal.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4323706698827301722==" List-Id: --===============4323706698827301722== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Thomas, And thank you for submitting this patch. We have had a couple of bug reports about this before and I think I had propo= sed a similar solution which was never confirmed to work by the person who re= ported the bug. I agree that this is a bug, but do we not want to set the tries to something = higher than 1? Just in case the network isn=E2=80=99t fully up yet? I would say that we can decrease the timeout because the service is usually r= unning on the same host and either responds immediately (less than a couple o= f milliseconds) or not at all. So 3 seconds and three tries is something that= would give you the same timeout but hopefully has a better chance to get a r= esponse if the network isn=E2=80=99t up, yet. Does that sound good to you? -Michael > On 31 Mar 2021, at 23:42, Thomas Cekal wrote: >=20 > Fix for Bug 12445: There is no proper way to distinguish between MS Azure a= nd a local > Hyper-V installation Procedure: try to get the metadata info from the > internal MS metadata service at IP 169.254.169.254 If this fails the system > is running on an local Hyper-V instance wget takes too long to exit if the = IP > is not reachable Added --timeout and --tries param to wget to reduce the > duation from 8 minutes to 10 seconds 10 seconds at one try should be enough > Signed-off-by: Thomas Cekal >=20 > --- > src/initscripts/helper/azure-setup | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/src/initscripts/helper/azure-setup b/src/initscripts/helper/az= ure-setup > index 5157712fc..a0d547588 100644 > --- a/src/initscripts/helper/azure-setup > +++ b/src/initscripts/helper/azure-setup > @@ -9,7 +9,7 @@ export PATH=3D/usr/local/sbin:/usr/local/bin:${PATH} > get() { > local file=3D"${1}" >=20 > - wget -qO - --header=3D"Metadata:true" "http://169.254.169.254/metadata/in= stance/${file}?api-version=3D2019-06-01&format=3Dtext" > + wget --timeout=3D10 --tries=3D1 -qO - --header=3D"Metadata:true" "http://= 169.254.169.254/metadata/instance/${file}?api-version=3D2019-06-01&format=3Dt= ext" > } >=20 > format_mac() { > --=20 > 2.17.1 >=20 --===============4323706698827301722==--