From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Patch for bugzilla #12050, try #2
Date: Mon, 15 Apr 2019 12:12:01 +0100 [thread overview]
Message-ID: <ED757673-6705-4E5F-8D83-C54B8E6ADD81@ipfire.org> (raw)
In-Reply-To: <trinity-5d286d80-f1d6-44ea-9382-c64f540e60e3-1555196686473@3c-app-gmx-bs47>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
Hi Bernhard,
I am happy that you are taking a look at this bug, but this is not how the process works.
We have a guide on how to submit patches to the mailing list:
https://wiki.ipfire.org/devel/submit-patches
There are a thousand reasons why we are doing this as we are doing it. Please follow it.
-Michael
> On 14 Apr 2019, at 00:04, Bernhard Bitsch <Bernhard.Bitsch(a)gmx.de> wrote:
>
> Please find appended the solution.
>
> Short description of the problem:
>
> After adding a new lease, you are in editing mode.
> All fields are set right, but a second click ('update' ) is necessary.
> With determining the exact mode 'add/edit' this second click can be avoided for new entries ( new MAC/IP combination).
>
> The patch adds determination of add/edit mode. If the MAC/IP pair exists in the list of fixed leases edit mode is selected, add mode is selected else.
>
> Sorry, did not produce the patch from git but by diffing changed file and the core 129 original.
>
> -Bernhard
>
> EDIT: produced an error by blind copy & paste, should correct with this patch.<dhcp.cgi.patch>
next prev parent reply other threads:[~2019-04-15 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 23:04 Bernhard Bitsch
2019-04-15 11:12 ` Michael Tremer [this message]
2019-04-15 18:49 ` Aw: " Bernhard Bitsch
2019-04-16 16:24 ` Matthias Fischer
2019-04-16 16:40 ` Matthias Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED757673-6705-4E5F-8D83-C54B8E6ADD81@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox