public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] unbound: speed-up remove forwarders
Date: Mon, 02 Mar 2020 12:06:09 +0000	[thread overview]
Message-ID: <EE0C61C2-8963-46E8-B43B-E52BCA3C438B@ipfire.org> (raw)
In-Reply-To: <20200301194113.16841-1-arne_f@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

Hi,

I am not entirely happy with the style of this fix, but it good enough to be shipped as a hot fix for now.

I will have a look to remove too many steps during the reload phase and that potentially includes finding another way how to handle Safe Search.

Thanks for looking into this.

Best,
-Michael

> On 1 Mar 2020, at 19:41, Arne Fitzenreiter <arne_f(a)ipfire.org> wrote:
> 
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
> src/initscripts/system/unbound | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/src/initscripts/system/unbound b/src/initscripts/system/unbound
> index b3185feab..0aab6cc8c 100644
> --- a/src/initscripts/system/unbound
> +++ b/src/initscripts/system/unbound
> @@ -595,6 +595,10 @@ case "$1" in
> 		# Call unbound-control and perform the reload
> 		/usr/sbin/unbound-control -q reload
> 
> +		if [ "$1" = "remove-forwarders" ]; then
> +			exit 0
> +		fi
> +
> 		# Dummy Resolve to wait for unbound
> 		resolve "ping.ipfire.org" &>/dev/null
> 
> -- 
> 2.17.1
> 


  reply	other threads:[~2020-03-02 12:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-01 19:41 Arne Fitzenreiter
2020-03-02 12:06 ` Michael Tremer [this message]
     [not found] <e6154825f7ed39f37f6a33e5bd60af3f@ipfire.org>
2020-03-02 16:08 ` Arne Fitzenreiter
2020-03-03 12:02   ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EE0C61C2-8963-46E8-B43B-E52BCA3C438B@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox