From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon To: development@lists.ipfire.org Subject: Re: [PATCH] time.cgi: add current date-time to this WebGUI page Date: Thu, 14 Mar 2024 12:19:28 -0500 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8027954931108307872==" List-Id: --===============8027954931108307872== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Comments below. Jon > On Mar 14, 2024, at 11:35 AM, Adolf Belka wrote: >=20 > Hi Jon, >=20 > On 14/03/2024 16:48, jon wrote: >> Michael - is this good to go?? >>=20 >> Jon >>=20 >>=20 >>> On Mar 12, 2024, at 11:18 AM, jon wrote: >>>=20 >>> Back when I was playing with NTP and tried to make it better in 2022 I th= ought it would have been helpful but it wasn=E2=80=99t my focus and I did not= have the skills to add it. Recently there were mentions about adding date/t= ime in the community. So it seemed like a good time to add (no pun intended). >>>=20 >>> Jon Murphy >>> jon.murphy(a)ipfire.org >>>=20 >>>=20 >>>=20 >>>> On Mar 12, 2024, at 5:10 AM, Michael Tremer wrote: >>>>=20 >>>> Hello Jon, >>>>=20 >>>> What is the motivation for this patch? >>>>=20 >>>> -Michael >>>>=20 >>>>> On 11 Mar 2024, at 23:45, Jon Murphy wrote: >>>>>=20 >>>>> - added words and date-time format to english (en.pl) >>>>> - other languages are needed >>>>> - seconds included since time is accurate to < .1s >=20 > I think this could be an issue. The time might be accurate to 0.1 secs but = it will only be updated when the browser page is refreshed. So I can imagine = people saying that the clock is not working because the seconds haven't chang= ed. >=20 > I have had that sort of problem in the past with the Connections Status pag= e where people complained that the Connection expiry time was not updating un= less they refreshed the browser page and they were sure it used to update eve= ry second in the past. >=20 > Certainly don't want to be ending up refreshing the browser page every seco= nd or less to show a change in the seconds value. >=20 > People will likely have a clock on the status panel of their OS desktop any= way so if the time matches on the hours and the minutes it will likely match = the seconds as well. >=20 I understand the concern and that was the reason for the "(as of last page lo= ad)" was added the the system time. The output looks like: "System time (as of last page load): 2024-03-14 at 11:40:22 CDT" And can easily be changed with the language files (I only did the `en.pl` fil= e) And since many other WebGUI pages do not auto-update, I think this will be OK= .=20 PS - If it becomes an issue, we could always add an "Update" button (like th= e log pages) to the right of the time. > Regards, >=20 > Adolf. >=20 >>>>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommit;h=3D2234e8aacac2e= 0d0b06dac4513585c15c2b3b440 >>>>>=20 >>>>> Code-by: Leo-Andres Hofmann >>>>> Signed-off-by: Jon Murphy >>>>> --- >>>>> html/cgi-bin/time.cgi | 4 ++++ >>>>> langs/en/cgi-bin/en.pl | 2 ++ >>>>> 2 files changed, 6 insertions(+) >>>>>=20 >>>>> diff --git a/html/cgi-bin/time.cgi b/html/cgi-bin/time.cgi >>>>> index 57a02a4b6..04c1e771f 100644 >>>>> --- a/html/cgi-bin/time.cgi >>>>> +++ b/html/cgi-bin/time.cgi >>>>> @@ -287,6 +287,10 @@ print <>>>> >>>>> END >>>>> ; >>>>> + >>>>> +my $now =3D strftime($Lang::tr{'timeformat'}, localtime); >>>>> +print "
$Lang::tr{'system time'}: $now"; >>>>> + >>>>> &Header::closebox(); >>>>> &Header::openbox('100%',1,$Lang::tr{'ntp sync'}); >>>>> print <>>>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl >>>>> index 667fb5d7e..2e036adb3 100644 >>>>> --- a/langs/en/cgi-bin/en.pl >>>>> +++ b/langs/en/cgi-bin/en.pl >>>>> @@ -2462,6 +2462,7 @@ >>>>> 'system log viewer' =3D> 'System Log Viewer', >>>>> 'system logs' =3D> 'System Logs', >>>>> 'system status information' =3D> 'System Status Information', >>>>> +'system time' =3D> 'System time (as of last page load)', >>>>> 'ta key' =3D> 'TLS-Authentification-Key', >>>>> 'taa zombieload2' =3D> 'TSX Async Abort/ZombieLoad v2', >>>>> 'tcp more reliable' =3D> 'TCP (more reliable)', >>>>> @@ -2490,6 +2491,7 @@ >>>>> 'time' =3D> 'Time', >>>>> 'time date manually reset' =3D> 'Time/Date manually reset.', >>>>> 'time server' =3D> 'Time Server', >>>>> +'timeformat' =3D> '%Y-%m-%d at %H:%M:%S %Z', >>>>> 'timeout must be a number' =3D> 'Timeout must be a number.', >>>>> 'title' =3D> 'Title', >>>>> 'to' =3D> 'To', >>>>> --=20 >>>>> 2.30.2 >>>>>=20 >>>>=20 >>>=20 >>=20 --===============8027954931108307872==--