From: ummeegge <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] BUG11466: fix routing.cgi the function call in routing.cgi was fixed to call the new "exact" function.
Date: Tue, 14 Nov 2017 14:11:59 +0100 [thread overview]
Message-ID: <EEE4E2E6-C6B4-4947-84A1-E4682535361C@ipfire.org> (raw)
In-Reply-To: <1510063806-13883-1-git-send-email-alexander.marx@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Hi Alex,
wanted to give you a fast feedback that this do not work here. I a get an error message "This is the GREEN subnet" whereby it makes no difference which subnet i do enter. The following line
$errormessage .= &General::check_net_internal_range($settings{'IP'});
solves it currently.
Greetings,
Erik
Am 07.11.2017 um 15:10 schrieb Alexander Marx:
> ---
> html/cgi-bin/routing.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/routing.cgi b/html/cgi-bin/routing.cgi
> index 15989bd..f2014e2 100644
> --- a/html/cgi-bin/routing.cgi
> +++ b/html/cgi-bin/routing.cgi
> @@ -154,7 +154,7 @@ if ($settings{'ACTION'} eq $Lang::tr{'add'}) {
> last;
> }
> #Is the network part of an internal network?
> - $errormessage .= &General::check_net_internal($settings{'IP'});
> + $errormessage .= &General::check_net_internal_exact($settings{'IP'});
> last;
> }
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-11-14 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 14:10 Alexander Marx
2017-11-14 13:11 ` ummeegge [this message]
2017-11-14 13:15 ` Michael Tremer
2017-11-14 13:22 ` ummeegge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EEE4E2E6-C6B4-4947-84A1-E4682535361C@ipfire.org \
--to=ummeegge@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox