From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jon Murphy <jcmurphy26@gmail.com>
To: development@lists.ipfire.org
Subject: Re: [PATCH] tftpd: add missing directory
Date: Sun, 24 Jul 2022 12:13:57 -0500
Message-ID: <EF1F4968-B9E3-4CEF-8BD1-82B38124A5AE@gmail.com>
In-Reply-To: <bfa7325a-57ee-a01d-f02a-2d44f0321ea4@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4267386521768233231=="
List-Id: <development.lists.ipfire.org>

--===============4267386521768233231==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Peter,

Since I am still learning I must defer to you.  I had assumed (bad word!) the=
=20
`mkdir -pv /var/tftpboot` below would have done both.

> shouldn't this go into the installation script of the add-on?

I think the answer is "yes".

Is the `mkdir -pv /var/tftpboot` below for the make build phase only?

If `mkdir -pv /var/tftpboot` belongs in the `install.sh` script then I can ad=
d it. =20
And I can remove the `mkdir -pv /var/tftpboot` from the LFS file.

Your guidance is needed!

Jon


> On Jul 24, 2022, at 7:52 AM, Peter M=C3=BCller <peter.mueller(a)ipfire.org>=
 wrote:
>=20
> Hello Jon,
>=20
> thank you for submitting this.
>=20
> Just a quick question: With regards to the tftpd rootfile (which currently =
does not
> include /var/tftpboot), isn't this change necessary during installation of =
the add-on
> (as well)? I. e., shouldn't this go into the installation script of the add=
-on?
>=20
> Or did I got this wrong?
>=20
> Thanks, and best regards,
> Peter M=C3=BCller
>=20
>=20
>> - starting tftpd currently throws "missing directory" error
>> - this change corrects the issue
>> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
>> ---
>> lfs/tftpd | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>> diff --git a/lfs/tftpd b/lfs/tftpd
>> index cb3d03415..f441c499c 100644
>> --- a/lfs/tftpd
>> +++ b/lfs/tftpd
>> @@ -1,7 +1,7 @@
>> ##########################################################################=
#####
>> #                                                                         =
    #
>> # IPFire.org - A linux based firewall                                     =
    #
>> -# Copyright (C) 2007-2021  IPFire Team  <info(a)ipfire.org>              =
       #
>> +# Copyright (C) 2007-2022  IPFire Team  <info(a)ipfire.org>              =
       #
>> #                                                                         =
    #
>> # This program is free software: you can redistribute it and/or modify    =
    #
>> # it under the terms of the GNU General Public License as published by    =
    #
>> @@ -34,7 +34,7 @@ DL_FROM    =3D $(URL_IPFIRE)
>> DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
>> TARGET     =3D $(DIR_INFO)/$(THISAPP)
>> PROG       =3D tftpd
>> -PAK_VER    =3D 2
>> +PAK_VER    =3D 3
>>   DEPS       =3D
>> @@ -87,6 +87,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>> 	cd $(DIR_APP) && make $(MAKETUNING)
>> 	cd $(DIR_APP) && make install
>> 	mv -fv /usr/sbin/in.tftpd /usr/sbin/tftpd
>> +	mkdir -pv /var/tftpboot
>> 	#install initscripts
>> 	$(call INSTALL_INITSCRIPTS,$(SERVICES))
>> 	@rm -rf $(DIR_APP)


--===============4267386521768233231==--