public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] installer: Harden mount options of /boot partition
Date: Thu, 28 Jul 2022 20:41:11 +0100	[thread overview]
Message-ID: <EFD20ABA-77D7-43C7-92D0-1E720517868F@ipfire.org> (raw)
In-Reply-To: <de573afc-f8ed-1cf8-949d-822b8801953f@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 28 Jul 2022, at 14:28, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> src/installer/hw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/installer/hw.c b/src/installer/hw.c
> index 12f8e793d..0ed6050b3 100644
> --- a/src/installer/hw.c
> +++ b/src/installer/hw.c
> @@ -1,7 +1,7 @@
> /*#############################################################################
> #                                                                             #
> # IPFire - An Open Source Firewall Distribution                               #
> -# Copyright (C) 2014 IPFire development team                                  #
> +# Copyright (C) 2007-2022  IPFire Team  <info(a)ipfire.org>                     #
> #                                                                             #
> # This program is free software: you can redistribute it and/or modify        #
> # it under the terms of the GNU General Public License as published by        #
> @@ -1134,7 +1134,7 @@ int hw_write_fstab(struct hw_destination* dest) {
> 		uuid = hw_get_uuid(dest->part_boot);
> 
> 		if (uuid) {
> -			fprintf(f, FSTAB_FMT, uuid, "/boot", "auto", "defaults", 1, 2);
> +			fprintf(f, FSTAB_FMT, uuid, "/boot", "auto", "defaults,nodev,noexec,nosuid", 1, 2);
> 			free(uuid);
> 		}
> 	}
> -- 
> 2.35.3


      reply	other threads:[~2022-07-28 19:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 13:28 Peter Müller
2022-07-28 19:41 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EFD20ABA-77D7-43C7-92D0-1E720517868F@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox