From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] stripper: Strip any PIE executables
Date: Wed, 06 Jul 2022 11:20:21 +0100
Message-ID: <F04ECA95-8E79-44FD-A58D-28624431E856@ipfire.org>
In-Reply-To: <c4f96c35-d68c-b336-28ec-5a404e06e75d@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0808919986564305202=="
List-Id: <development.lists.ipfire.org>

--===============0808919986564305202==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Did I not submit an update to that somewhere anyways?

> On 6 Jul 2022, at 11:00, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wro=
te:
>=20
> Hello Michael,
>=20
> thanks for your swift response.
>=20
> Okay, I will then just bump the version number of dnsdist.
>=20
> All the best,
> Peter M=C3=BCller
>=20
>=20
>> Good question. I did not even think about this.
>>=20
>> I could not find many executables that fell into this category. Maybe abou=
t 10. Out of those, dnsdist was the largest one - by far.
>>=20
>> So I would say, it isn=E2=80=99t worth it except for dnsdist.
>>=20
>> -Michael
>>=20
>>> On 6 Jul 2022, at 10:56, Peter M=C3=BCller <peter.mueller(a)ipfire.org> w=
rote:
>>>=20
>>> Hello Michael,
>>>=20
>>> just a short follow-up question on this: Do we need to re-ship all affect=
ed packages again?
>>> Or is it fine to let users benefit from stripped PIE executables when we =
update affected
>>> components anyway?
>>>=20
>>> Thanks, and best regards,
>>> Peter M=C3=BCller
>>>=20
>>>=20
>>>> Reviewed-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>>>>=20
>>>>> Fixes: #12894
>>>>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>>>> ---
>>>>>  src/stripper | 4 ++++
>>>>>  1 file changed, 4 insertions(+)
>>>>>=20
>>>>> diff --git a/src/stripper b/src/stripper
>>>>> index fadbc514b..4014f03a4 100755
>>>>> --- a/src/stripper
>>>>> +++ b/src/stripper
>>>>> @@ -38,6 +38,10 @@ function _strip() {
>>>>>              args+=3D( "--strip-all" )
>>>>>              ;;
>>>>>  +        *Type:*"DYN (Position-Independent Executable file)"*)
>>>>> +            args+=3D( "--strip-all" )
>>>>> +            ;;
>>>>> +
>>>>>          # Binaries
>>>>>          *Type:*"EXEC (Executable file)"*)
>>>>>              args+=3D( "--strip-all" )
>>=20


--===============0808919986564305202==--